Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick efdfe711dc5 from chromium #32791

Merged
merged 3 commits into from Feb 10, 2022

Conversation

deepak1556
Copy link
Member

Subject: Do not select vulkan device based on the passed in gpu_info on Linux

On linux dual GPU setup, we cannot detect the active GPU correctly.
It causes problems for GL and Vulkan interop. So we would to use
ANGLE vulkan backend when vulkan is enabled. So we can choose the same
GPU for both vulkan and GL. So for this CL, we will not create vulkan
device based on passed in gpu_info anymore, instead GPU device will be
selected by the order of
(discrete GPU > integrated GPU > virtual GPU > CPU simulated GPU).
And we will use the same logic in ANGLE vulkan backend as well.

Bug: 1260869
Change-Id: I6fb79a4e6ce1710e4809cd63a0f7738955a8e2d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3242785
Commit-Queue: Peng Huang penghuang@chromium.org
Commit-Queue: Vasiliy Telezhnikov vasilyt@chromium.org
Auto-Submit: Peng Huang penghuang@chromium.org
Reviewed-by: Vasiliy Telezhnikov vasilyt@chromium.org
Cr-Commit-Position: refs/heads/main@{#934696}

Notes: Security: backported fix for chromium:1260869

@deepak1556 deepak1556 requested a review from a team as a code owner February 8, 2022 09:31
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 8, 2022
@deepak1556 deepak1556 added 15-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes labels Feb 8, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 8, 2022
@zcbenz zcbenz merged commit 0d1b7be into 15-x-y Feb 10, 2022
@zcbenz zcbenz deleted the robo/cherry_pick_3242963_15_x_y branch February 10, 2022 06:13
@release-clerk
Copy link

release-clerk bot commented Feb 10, 2022

Release Notes Persisted

Security: backported fix for chromium:1260869

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
15-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants