Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 349a35b19 from chromium #32803

Merged
merged 2 commits into from Feb 21, 2022

Conversation

deepak1556
Copy link
Member

Subject: Handle PotentiallyDanglingMarkup() for CSSImageValue

The flag was lost in the KURL -> String -> KURL conversions. Store the
flag on CSSImageValue and always re-resolve from the original relative
url before fetching when that flag is set. The blocking happens in
BaseFetchContext::CanRequestInternal().

Bug: 1039885
Change-Id: Ia5777739a0ee0bee591163873926d19e0ea014bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226142
Reviewed-by: Anders Hartvoll Ruud andruud@chromium.org
Reviewed-by: Mike West mkwst@chromium.org
Commit-Queue: Rune Lillesveen futhark@chromium.org
Cr-Commit-Position: refs/heads/main@{#932004}

Notes: Security: backported fix for chromium:1039885

@deepak1556 deepak1556 requested a review from a team as a code owner February 8, 2022 10:45
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 8, 2022
@deepak1556 deepak1556 added 16-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes labels Feb 8, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 8, 2022
@zcbenz zcbenz merged commit 88074b0 into 16-x-y Feb 21, 2022
@zcbenz zcbenz deleted the robo/cherry_pick_3226142_16_x_y branch February 21, 2022 07:36
@release-clerk
Copy link

release-clerk bot commented Feb 21, 2022

Release Notes Persisted

Security: backported fix for chromium:1039885

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
16-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants