Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick a1c1ec1ea9 from chromium #32807

Merged
merged 2 commits into from Feb 17, 2022

Conversation

deepak1556
Copy link
Member

Subject: Use AXNodeID rather than AXNode* in AXEventGenerator tree events.

We suspect that sometimes AXNodes are destroyed while processing events.
Specifically, we suspect that the extra mac nodes that are created for
table column and row headers when VoiceOver requests them are destroyed
if an ancestor up the chain is modified. In order to safeguard against
the possibility of an AXNode* becoming stale, we will store AXNodeIDs in
the list of tree events. This way, when the tree event is used, we can
first check for the validity of the AXNodeID before using the
corresponding AXNode.

Bug: 1262967
Change-Id: Ifa2b23544fff532b379857a637f417d5f639c7ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3244046
Commit-Queue: Abigail Klein abigailbklein@google.com
Reviewed-by: Aaron Leventhal aleventhal@chromium.org
Reviewed-by: Nektarios Paisios nektar@chromium.org
Cr-Commit-Position: refs/heads/main@{#937698}

Notes: Security: backported fix for chromium:1262967

@deepak1556 deepak1556 requested a review from a team as a code owner February 8, 2022 10:51
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 8, 2022
@deepak1556 deepak1556 added 16-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes labels Feb 8, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 8, 2022
@zcbenz zcbenz merged commit c2e6903 into 16-x-y Feb 17, 2022
@zcbenz zcbenz deleted the robo/cherry_pick_3244046_16_x_y branch February 17, 2022 05:54
@release-clerk
Copy link

release-clerk bot commented Feb 17, 2022

Release Notes Persisted

Security: backported fix for chromium:1262967

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
16-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants