chore: bump chromium to 102.0.4971.0 (main) #33454

electron-roller · 2022-03-26T13:00:19Z

Updating Chromium to 102.0.4971.0.

See all changes in 102.0.4962.3..102.0.4971.0

Notes: Updated Chromium to 102.0.4971.0.

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3101519 build: add popup_preventer.cc, .h to our library. It's needed because FullscreenController, we were already using, started aggregating a PopupPreventer in 3101519.

…dow support" This reverts commit fc215cb. Adding popup_preventer might not be the right solution; there are cascading dependencies.

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3551449 chore: fix code shear in patches/chromium/printing.patch

Refs https://chromium-review.googlesource.com/c/chromium/src/+/3101519 PopupunderPreventer is not useful in //electron since the window attributes are controlled by the user via setWindowOpenHandler.

https://chromium-review.googlesource.com/c/chromium/src/+/3503410

https://chromium-review.googlesource.com/c/chromium/src/+/3541939

https://chromium-review.googlesource.com/c/chromium/src/+/3537735

Refs https://chromium-review.googlesource.com/c/chromium/src/+/3544199 https://developer.apple.com/documentation/screencapturekit/capturing_screen_content_in_macos

codebytere · 2022-03-30T08:07:03Z

.circleci/build_config.yml

@@ -59,7 +59,7 @@ executors:
        description: "xcode version"
        default: "12.4.0"
        type: enum
-        enum: ["12.4.0", "13.2.1"]
+        enum: ["12.4.0", "13.3.0"]


@MarshallOfSound has this been added to build-tools?

codebytere · 2022-03-30T08:09:08Z

patches/chromium/fix_patch_out_permissions_checks_in_exclusive_access.patch

+   // Tracks related popups that lost activation or were shown without activation
+   // during content fullscreen sessions. This also activates the popups when
+   // fullscreen exits, to prevent sites from creating persisent popunders.
+   std::unique_ptr<PopunderPreventer> popunder_preventer_;


We should consider adding a dummy implementation for this instead of commenting it all out and bloating the patch

Yeah I didn't go with it mainly because we didn't want to maintain any sources inside chromium_src, if there is a majority preferring mock classes vs patch, I can adjust this change accordingly.

It looks like upstream is still churning this code.

I don't have any opinion on #if 0 vs mock, but it we are going to consider using a mock here, that consideration would make more sense after upstream stops moving so much.

I think the patch is necessary because we are building chrome/browser/ui/exclusive_access/fullscreen_controller.cc (added via #31572).

ckerr · 2022-03-30T16:39:55Z

patches/chromium/fix_patch_out_permissions_checks_in_exclusive_access.patch

+   // Tracks related popups that lost activation or were shown without activation
+   // during content fullscreen sessions. This also activates the popups when
+   // fullscreen exits, to prevent sites from creating persisent popunders.
+   std::unique_ptr<PopunderPreventer> popunder_preventer_;


It looks like upstream is still churning this code.

I don't have any opinion on #if 0 vs mock, but it we are going to consider using a mock here, that consideration would make more sense after upstream stops moving so much.

release-clerk · 2022-03-30T18:09:01Z

Release Notes Persisted

Updated Chromium to 102.0.4971.0.

trop · 2022-03-30T18:09:13Z

I was unable to backport this PR to "19-x-y" cleanly;
you will need to perform this backport manually.

jkleinsc · 2022-03-30T23:05:16Z

/trop run backport

trop · 2022-03-30T23:05:18Z

The backport process for this PR has been manually initiated - here we go! :D

* chore: bump chromium in DEPS to 102.0.4965.0 * chore: 3-way merge of chromium/printing.patch * chore: update patch shear in chromium/picture-in-picture.patch * chore: update patches * 3101519: Window Placement: Prototype fullscreen companion window support Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3101519 build: add popup_preventer.cc, .h to our library. It's needed because FullscreenController, we were already using, started aggregating a PopupPreventer in 3101519. * chore: bump chromium in DEPS to 102.0.4967.0 * Revert "3101519: Window Placement: Prototype fullscreen companion window support" This reverts commit fc215cb. Adding popup_preventer might not be the right solution; there are cascading dependencies. * 3551449: Add service-based usage for system print settings Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3551449 chore: fix code shear in patches/chromium/printing.patch * chore: update patches * chore: bump chromium in DEPS to 102.0.4969.0 * chore: update patches * chore: bump chromium in DEPS to 102.0.4971.0 * chore: update fix_patch_out_permissions_checks_in_exclusive_access.patch Refs https://chromium-review.googlesource.com/c/chromium/src/+/3101519 PopupunderPreventer is not useful in //electron since the window attributes are controlled by the user via setWindowOpenHandler. * chore: update patches * Add FirstPartySetsHandler as a interface class in content API. https://chromium-review.googlesource.com/c/chromium/src/+/3503410 * Create a new MediaStreamRequestType for GetOpenDevice https://chromium-review.googlesource.com/c/chromium/src/+/3541939 * Support site isolation for <webview> tags in WebViewRendererState. https://chromium-review.googlesource.com/c/chromium/src/+/3537735 * ci: update xcode version Refs https://chromium-review.googlesource.com/c/chromium/src/+/3544199 https://developer.apple.com/documentation/screencapturekit/capturing_screen_content_in_macos Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: deepak1556 <hop2deep@gmail.com> (cherry picked from commit b711860)

* chore: bump chromium in DEPS to 102.0.4973.0 * chore: bump chromium to 102.0.4971.0 (main) (#33454) * chore: bump chromium in DEPS to 102.0.4965.0 * chore: 3-way merge of chromium/printing.patch * chore: update patch shear in chromium/picture-in-picture.patch * chore: update patches * 3101519: Window Placement: Prototype fullscreen companion window support Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3101519 build: add popup_preventer.cc, .h to our library. It's needed because FullscreenController, we were already using, started aggregating a PopupPreventer in 3101519. * chore: bump chromium in DEPS to 102.0.4967.0 * Revert "3101519: Window Placement: Prototype fullscreen companion window support" This reverts commit fc215cb. Adding popup_preventer might not be the right solution; there are cascading dependencies. * 3551449: Add service-based usage for system print settings Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3551449 chore: fix code shear in patches/chromium/printing.patch * chore: update patches * chore: bump chromium in DEPS to 102.0.4969.0 * chore: update patches * chore: bump chromium in DEPS to 102.0.4971.0 * chore: update fix_patch_out_permissions_checks_in_exclusive_access.patch Refs https://chromium-review.googlesource.com/c/chromium/src/+/3101519 PopupunderPreventer is not useful in //electron since the window attributes are controlled by the user via setWindowOpenHandler. * chore: update patches * Add FirstPartySetsHandler as a interface class in content API. https://chromium-review.googlesource.com/c/chromium/src/+/3503410 * Create a new MediaStreamRequestType for GetOpenDevice https://chromium-review.googlesource.com/c/chromium/src/+/3541939 * Support site isolation for <webview> tags in WebViewRendererState. https://chromium-review.googlesource.com/c/chromium/src/+/3537735 * ci: update xcode version Refs https://chromium-review.googlesource.com/c/chromium/src/+/3544199 https://developer.apple.com/documentation/screencapturekit/capturing_screen_content_in_macos Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: deepak1556 <hop2deep@gmail.com> (cherry picked from commit b711860) Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>

* chore: bump chromium in DEPS to 102.0.4965.0 * chore: 3-way merge of chromium/printing.patch * chore: update patch shear in chromium/picture-in-picture.patch * chore: update patches * 3101519: Window Placement: Prototype fullscreen companion window support Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3101519 build: add popup_preventer.cc, .h to our library. It's needed because FullscreenController, we were already using, started aggregating a PopupPreventer in 3101519. * chore: bump chromium in DEPS to 102.0.4967.0 * Revert "3101519: Window Placement: Prototype fullscreen companion window support" This reverts commit fc215cb. Adding popup_preventer might not be the right solution; there are cascading dependencies. * 3551449: Add service-based usage for system print settings Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3551449 chore: fix code shear in patches/chromium/printing.patch * chore: update patches * chore: bump chromium in DEPS to 102.0.4969.0 * chore: update patches * chore: bump chromium in DEPS to 102.0.4971.0 * chore: update fix_patch_out_permissions_checks_in_exclusive_access.patch Refs https://chromium-review.googlesource.com/c/chromium/src/+/3101519 PopupunderPreventer is not useful in //electron since the window attributes are controlled by the user via setWindowOpenHandler. * chore: update patches * Add FirstPartySetsHandler as a interface class in content API. https://chromium-review.googlesource.com/c/chromium/src/+/3503410 * Create a new MediaStreamRequestType for GetOpenDevice https://chromium-review.googlesource.com/c/chromium/src/+/3541939 * Support site isolation for <webview> tags in WebViewRendererState. https://chromium-review.googlesource.com/c/chromium/src/+/3537735 * ci: update xcode version Refs https://chromium-review.googlesource.com/c/chromium/src/+/3544199 https://developer.apple.com/documentation/screencapturekit/capturing_screen_content_in_macos Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: deepak1556 <hop2deep@gmail.com>

electron-roller bot requested a review from a team as a code owner March 26, 2022 13:00

electron-roller bot added no-backport semver/patch backwards-compatible bug fixes labels Mar 26, 2022

electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 26, 2022

electron-roller bot requested a review from a team as a code owner March 26, 2022 20:23

ckerr force-pushed the roller/chromium/main branch from 000468e to 054139a Compare March 26, 2022 21:48

electron-roller bot changed the title ~~chore: bump chromium to 102.0.4965.0 (main)~~ chore: bump chromium to 102.0.4967.0 (main) Mar 27, 2022

electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 27, 2022

electron-roller bot changed the title ~~chore: bump chromium to 102.0.4967.0 (main)~~ chore: bump chromium to 102.0.4969.0 (main) Mar 28, 2022

electron-roller bot changed the title ~~chore: bump chromium to 102.0.4969.0 (main)~~ chore: bump chromium to 102.0.4971.0 (main) Mar 29, 2022

electron-roller bot and others added 17 commits March 30, 2022 07:55

chore: bump chromium in DEPS to 102.0.4965.0

b8d13a5

chore: 3-way merge of chromium/printing.patch

98922e1

chore: update patch shear in chromium/picture-in-picture.patch

47a8fd6

chore: update patches

ebbfa40

chore: bump chromium in DEPS to 102.0.4967.0

a23ba62

Revert "3101519: Window Placement: Prototype fullscreen companion win…

ffaacb9

…dow support" This reverts commit fc215cb. Adding popup_preventer might not be the right solution; there are cascading dependencies.

3551449: Add service-based usage for system print settings

cc7884e

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3551449 chore: fix code shear in patches/chromium/printing.patch

chore: update patches

b188c25

chore: bump chromium in DEPS to 102.0.4969.0

8e3aa89

chore: update patches

d14ef8c

chore: bump chromium in DEPS to 102.0.4971.0

1809755

chore: update fix_patch_out_permissions_checks_in_exclusive_access.patch

9e69ee3

Refs https://chromium-review.googlesource.com/c/chromium/src/+/3101519 PopupunderPreventer is not useful in //electron since the window attributes are controlled by the user via setWindowOpenHandler.

chore: update patches

71b4111

Add FirstPartySetsHandler as a interface class in content API.

00465d5

https://chromium-review.googlesource.com/c/chromium/src/+/3503410

Create a new MediaStreamRequestType for GetOpenDevice

aed75ed

https://chromium-review.googlesource.com/c/chromium/src/+/3541939

Support site isolation for <webview> tags in WebViewRendererState.

b0f4daf

https://chromium-review.googlesource.com/c/chromium/src/+/3537735

deepak1556 force-pushed the roller/chromium/main branch from 1e2c3a6 to b0f4daf Compare March 29, 2022 22:55

deepak1556 added the roller/pause label Mar 29, 2022

ci: update xcode version

4d433ac

Refs https://chromium-review.googlesource.com/c/chromium/src/+/3544199 https://developer.apple.com/documentation/screencapturekit/capturing_screen_content_in_macos

codebytere reviewed Mar 30, 2022

View reviewed changes

codebytere approved these changes Mar 30, 2022

View reviewed changes

codebytere mentioned this pull request Mar 30, 2022

Add Xcode 13.3.0 electron/build-tools#352

Closed

ckerr approved these changes Mar 30, 2022

View reviewed changes

jkleinsc added target/19-x-y and removed no-backport labels Mar 30, 2022

VerteDinde approved these changes Mar 30, 2022

View reviewed changes

jkleinsc approved these changes Mar 30, 2022

View reviewed changes

jkleinsc merged commit b711860 into main Mar 30, 2022

jkleinsc deleted the roller/chromium/main branch March 30, 2022 18:08

trop bot added needs-manual-bp/19-x-y and removed target/19-x-y labels Mar 30, 2022

jkleinsc removed the needs-manual-bp/19-x-y label Mar 31, 2022

jkleinsc mentioned this pull request Apr 7, 2022

Symbol generation is failing for 32-bit Windows release builds for nightlies and 19-x-y #33652

Closed

commit-lint bot mentioned this pull request May 27, 2022

[pull] main from electron:main Blaquez-home/electron#3

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: bump chromium to 102.0.4971.0 (main) #33454

chore: bump chromium to 102.0.4971.0 (main) #33454

electron-roller bot commented Mar 26, 2022 •

edited

codebytere Mar 30, 2022

codebytere Mar 30, 2022

deepak1556 Mar 30, 2022

ckerr Mar 30, 2022 •

edited

jkleinsc Mar 30, 2022

ckerr Mar 30, 2022 •

edited

release-clerk bot commented Mar 30, 2022

trop bot commented Mar 30, 2022

jkleinsc commented Mar 30, 2022

trop bot commented Mar 30, 2022

chore: bump chromium to 102.0.4971.0 (main) #33454

chore: bump chromium to 102.0.4971.0 (main) #33454

Conversation

electron-roller bot commented Mar 26, 2022 • edited

codebytere Mar 30, 2022

Choose a reason for hiding this comment

codebytere Mar 30, 2022

Choose a reason for hiding this comment

deepak1556 Mar 30, 2022

Choose a reason for hiding this comment

ckerr Mar 30, 2022 • edited

Choose a reason for hiding this comment

jkleinsc Mar 30, 2022

Choose a reason for hiding this comment

ckerr Mar 30, 2022 • edited

Choose a reason for hiding this comment

release-clerk bot commented Mar 30, 2022

trop bot commented Mar 30, 2022

jkleinsc commented Mar 30, 2022

trop bot commented Mar 30, 2022

electron-roller bot commented Mar 26, 2022 •

edited

ckerr Mar 30, 2022 •

edited

ckerr Mar 30, 2022 •

edited