chore: remove redundant code in node integration #33500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
approved these changes
Mar 29, 2022
|
Linux CI is green https://app.circleci.com/pipelines/github/electron/electron/51237/workflows/0095b693-9d63-4888-a57e-2097056d0fab , status wasn't signalled back to github. |
|
No Release Notes |
bavulapati
pushed a commit
to bavulapati/electron
that referenced
this pull request
Apr 29, 2022
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
In the node integration code, on Linux and macOS we have code checking whether the backend fd is changed to prevent duplicate initializations. But since the backend fd of default uv loop is never changed, the code is essentially just preventing double initialization, which is identical to the Windows code.
This PR removes redundant check of backend fd and changes the code to use same routine on all platforms.
The code was introduced in #25869 and #27582, and I can verify the original issues are not regressed.
Release Notes
Notes: none