Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: build when pdf component is disabled #33513

Merged
merged 1 commit into from Mar 30, 2022
Merged

fix: build when pdf component is disabled #33513

merged 1 commit into from Mar 30, 2022

Conversation

deepak1556
Copy link
Member

Description of Change

Cleanup from #33091 and also uses reuses constants from upstream where possible.

Release Notes

Notes: no-notes

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 30, 2022
@deepak1556 deepak1556 requested a review from a team March 30, 2022 08:28
nornagon
nornagon approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@nornagon nornagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@nornagon nornagon merged commit afe0116 into main Mar 30, 2022
@nornagon nornagon deleted the robo/fix_no_pdf_build branch March 30, 2022 18:55
@release-clerk
Copy link

release-clerk bot commented Mar 30, 2022

No Release Notes

@deepak1556 deepak1556 mentioned this pull request Apr 8, 2022
Merged
2 tasks
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 8, 2022
@deepak1556 deepak1556 added semver/patch backwards-compatible bug fixes new-pr 🌱 PR opened in the last 24 hours and removed semver/none no-backport labels Apr 8, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 8, 2022
@deepak1556
Copy link
Member Author

/trop run backport-to 19-x-y

@trop
Copy link
Contributor

trop bot commented Apr 8, 2022

The backport process for this PR has been manually initiated - sending your PR to 19-x-y!

@trop trop bot mentioned this pull request Apr 8, 2022
Merged
@trop
Copy link
Contributor

trop bot commented Apr 8, 2022

I have automatically backported this PR to "19-x-y", please check out #33666

nornagon added a commit that referenced this pull request Apr 11, 2022
@nornagon
cherry-pick #33513
0b1fe48
bavulapati pushed a commit to bavulapati/electron that referenced this pull request Apr 29, 2022
@deepak1556 @bavulapati
fix: build when pdf component is disabled (electron#33513)
6fdda92
@commit-lint commit-lint bot mentioned this pull request May 30, 2022
Open
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@deepak1556 @khalwa
fix: build when pdf component is disabled (electron#33513)
cbfee64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@deepak1556 @nornagon @codebytere @miniak