New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the "-" in BrowserWindow's option names #3400
Conversation
Otherwise a window's options is possible to be affected by others.
Remove the "-" in BrowserWindow's option names
No more quotes around option names LGTM 😄 |
I forgot that, it has been updated now. |
Thanks! |
just tried to get a preload script running based on the wiki documentation and electron version 0.34.3. i could not get this to work properly. first secondly while i could get
expose-window-apis.js
|
the documentation was a little fuzzy here i got it working see #1753 (comment) |
This PR was merged after v0.34.3 and it's first available in v0.35.0. For v0.34.3 you should use the older dashed options. |
e.g.
min-width
=>minWidth
. Old styles are still accepted for compatibility.Fix #2397.
Refs #2544.