Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix nativeModulesEnabled in spec/webview-spec.js #34027

Merged
merged 1 commit into from May 4, 2022
Merged

test: fix nativeModulesEnabled in spec/webview-spec.js #34027

merged 1 commit into from May 4, 2022

Conversation

miniak
Copy link
Contributor

@miniak miniak commented May 3, 2022 •
edited

Description of Change

The logic was flipped

electron/spec/webview-spec.js

Line 10 in 7dee517

const nativeModulesEnabled = process.env.ELECTRON_SKIP_NATIVE_MODULE_TESTS;

It needs to be

electron/spec-main/modules-spec.ts

Line 13 in 7dee517

const nativeModulesEnabled = !process.env.ELECTRON_SKIP_NATIVE_MODULE_TESTS;

electron/spec/static/main.js

Line 90 in 7dee517

global.nativeModulesEnabled = !process.env.ELECTRON_SKIP_NATIVE_MODULE_TESTS;

Depends on #34026

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes

Release Notes

Notes: none

@miniak miniak changed the title test: const nativeModulesEnabled = !process.env.ELECTRON_SKIP_NATIVE_MODULE_TESTS; test: fix nativeModulesEnabled in spec/webview-spec.js May 3, 2022
@miniak miniak force-pushed the miniak/spec-native-modules-enabled branch from 19c686b to 7b1d12f Compare May 3, 2022 03:03
@miniak miniak marked this pull request as draft May 3, 2022 13:44
@miniak miniak force-pushed the miniak/spec-native-modules-enabled branch from 7b1d12f to 5dd27fc Compare May 3, 2022 18:25
@miniak miniak marked this pull request as ready for review May 3, 2022 18:45
@MarshallOfSound MarshallOfSound merged commit 349cd98 into main May 4, 2022
@MarshallOfSound MarshallOfSound deleted the miniak/spec-native-modules-enabled branch May 4, 2022 06:56
@release-clerk
Copy link

release-clerk bot commented May 4, 2022

No Release Notes

This was referenced May 4, 2022
Merged
Merged
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented May 4, 2022

I have automatically backported this PR to "15-x-y", please check out #34063

@trop
Copy link
Contributor

trop bot commented May 4, 2022

I have automatically backported this PR to "17-x-y", please check out #34064

@trop
Copy link
Contributor

trop bot commented May 4, 2022

I have automatically backported this PR to "16-x-y", please check out #34065

@trop trop bot added the in-flight/17-x-y label May 4, 2022
@trop
Copy link
Contributor

trop bot commented May 4, 2022

I have automatically backported this PR to "19-x-y", please check out #34066

@trop
Copy link
Contributor

trop bot commented May 4, 2022

I have automatically backported this PR to "18-x-y", please check out #34067

@commit-lint commit-lint bot mentioned this pull request Jul 5, 2022
Open
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@miniak @khalwa
test: fix nativeModulesEnabled in spec/webview-spec.js (electron#34027)
3b8a3ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deermichel deermichel deermichel approved these changes

Assignees
No one assigned
Labels
semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miniak @deermichel @MarshallOfSound