Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use webContents.setWindowOpenHandler() in specs #34310

Merged
merged 1 commit into from
May 23, 2022
Merged

test: use webContents.setWindowOpenHandler() in specs #34310

merged 1 commit into from
May 23, 2022

Conversation

miniak
Copy link
Contributor

@miniak miniak commented May 21, 2022 •
edited

Description of Change

The new-window event is deprecated.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are changed or added

Release Notes

Notes: none

@miniak miniak self-assigned this May 21, 2022
@codebytere codebytere merged commit 09a80ea into main May 23, 2022
@codebytere codebytere deleted the miniak/spec-new-window branch May 23, 2022 14:39
@release-clerk
Copy link

release-clerk bot commented May 23, 2022

No Release Notes

@miniak miniak mentioned this pull request Jun 12, 2022
Merged
3 tasks
@commit-lint commit-lint bot mentioned this pull request Jul 27, 2022
Open
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@miniak @khalwa
test: use webContents.setWindowOpenHandler() in specs (electron#34310)
c6a27ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees

@miniak miniak

Labels
no-backport semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@miniak @codebytere