test: re-enable shared worker webview test #34338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
reviewed
May 24, 2022
| const webview = new WebView(); | ||
| webview.addEventListener('console-message', (e) => { | ||
| console.log(e); | ||
| }); | ||
| const eventPromise = waitForEvent(webview, 'ipc-message'); | ||
| webview.src = `file://${fixtures}/pages/shared_worker.html`; | ||
| webview.setAttribute('webpreferences', 'nodeIntegration, nodeIntegrationInWorker'); | ||
| webview.setAttribute('webpreferences', 'nodeIntegration, nodeIntegrationInWorker, contextIsolation=no'); |
There was a problem hiding this comment.
Good opportunity to refactor the test to work with context isolation https://github.com/electron/electron/blob/main/spec/fixtures/pages/shared_worker.html :)
nornagon
approved these changes
May 24, 2022
zcbenz
approved these changes
May 31, 2022
zcbenz
force-pushed
the
re-enable-shared-worker-test
branch
from
97f0a73
to
ae401ce
Compare
jkleinsc
approved these changes
Jun 2, 2022
|
No Release Notes |
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The crash no longer occurs locally and it passes as soon as
contextIsolation=nois set as an attribute.Checklist
npm testpassesRelease Notes
Notes: none.