Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add will-frame-navigate event #34418

Merged
merged 27 commits into from
Mar 28, 2023
Merged

feat: add will-frame-navigate event #34418

merged 27 commits into from
Mar 28, 2023

Commits on Sep 7, 2022

  1. feat: add will-navigate-in-frame event to webContents

    @itsananderson
    itsananderson committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    2b9d6ec View commit details
    Browse the repository at this point in the history

  2. docs: add documentation for webview will-frame-navigate event

    @itsananderson
    itsananderson committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    c56ebdb View commit details
    Browse the repository at this point in the history

  3. feat: Eliminate isInPlace argument from will-frame-navigate event

    @itsananderson
    itsananderson committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    0dbc394 View commit details
    Browse the repository at this point in the history

  4. fix: Fire will-frame-navigate before will-navigate

    @itsananderson
    itsananderson committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    5227c91 View commit details
    Browse the repository at this point in the history

  5. feat: send will-frame-navigate with a WebFrameMain in the event details

    @itsananderson
    itsananderson committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    42faabd View commit details
    Browse the repository at this point in the history

  6. docs: Update WebContents docs for new API signature

    @itsananderson
    itsananderson committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    64f3379 View commit details
    Browse the repository at this point in the history

  7. feat: Add custom event forwarding for <webview> will-frame-navigate

    @itsananderson
    itsananderson committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    28c9eed View commit details
    Browse the repository at this point in the history

  8. fix: wrap WebFrameMain so it can be sent as an event

    @itsananderson
    itsananderson committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    29edf5e View commit details
    Browse the repository at this point in the history

  9. test: update webContents and <webview> tests to match new signatures

    @itsananderson
    itsananderson committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    6bf2820 View commit details
    Browse the repository at this point in the history

  10. chore: undo unnecessary change

    @itsananderson
    itsananderson committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    361eb29 View commit details
    Browse the repository at this point in the history

  11. fix: don't switch will-navigate to use EmitNavigationEventDetails

    @itsananderson
    itsananderson committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    164ac12 View commit details
    Browse the repository at this point in the history

  12. test: clean up will-navigate and will-frame-navigate tests for <webview>

    @itsananderson
    itsananderson committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    d64d558 View commit details
    Browse the repository at this point in the history

  13. chore: apply lint fixes

    @itsananderson
    itsananderson committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    aadd9aa View commit details
    Browse the repository at this point in the history

  14. chore: move GetRenderFrameHost helper into anonymous namespace

    @itsananderson
    itsananderson committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    c14985a View commit details
    Browse the repository at this point in the history

  15. docs: auto-generate WillFrameNavigateDetails rather than defining it … 

    …manually
    @itsananderson
    itsananderson committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    af46d89 View commit details
    Browse the repository at this point in the history

  16. test: Update <webview> tests to actually pass under new spec runner

    @itsananderson
    itsananderson committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    76baaf2 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2022

  1. docs: Add section explaining relationship between various nav events

    @itsananderson
    itsananderson committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    717e578 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2023

  1. Merge remote-tracking branch 'upstream/main' into add-will-frame-navi… 

    …gate
    @itsananderson
    itsananderson committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    4d83aba View commit details
    Browse the repository at this point in the history

  2. test: Add some tests to ensure navigation event order doesn't silentl… 

    …y change
    @itsananderson
    itsananderson committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    d86c324 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2023

  1. test: Always monitor all nav events to ensure unexpected ones don't fire

    @itsananderson
    itsananderson committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    577dfad View commit details
    Browse the repository at this point in the history

  2. test: Add test to verify in-page navigation event order

    @itsananderson
    itsananderson committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    8c64f3a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into add-will-frame-navigate

    @itsananderson
    itsananderson committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    f534b94 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2023

  1. Merge branch 'main' into add-will-frame-navigate

    @miniak
    miniak committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    a8087d4 View commit details
    Browse the repository at this point in the history

  2. feat: Change to new style where extra params are exposed as event props

    @itsananderson
    itsananderson committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    14937f8 View commit details
    Browse the repository at this point in the history

  3. fix: Remove unused EmitNavigationEventDetails

    @itsananderson
    itsananderson committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    aa126b0 View commit details
    Browse the repository at this point in the history

  4. fix: Update tests to use new async helpers

    @itsananderson
    itsananderson committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    addd531 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. docs: Rename and reorder sections documenting navigation events

    @itsananderson
    itsananderson committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    37af256 View commit details
    Browse the repository at this point in the history