chore: fix spelling errors in multiple files #34574

jsoref · 2022-06-15T01:21:07Z

Description of Change

Fixes various typos in electron

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at jsoref@da81883#commitcomment-76118321

The action reports that the changes in this PR would make it happy: jsoref@39e7178

Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.

I will be annotating this PR, and I fully expect to be asked to drop certain files.

Checklist

PR description included and stakeholders cc'd
npm test passes
tests are changed or added
PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: none

jsoref

The vast majority of fixes were suggested by Google Sheets.

All fault is mine.

.circleci/config/base.yml

appveyor.yml

docs/api/app.md

docs/tutorial/electron-versioning.md

script/release/uploaders/upload.py

spec-main/api-session-spec.ts

spec-main/release-notes-spec.ts

spec/ts-smoke/electron/main.ts

VerteDinde

Hey @jsoref, thanks for opening a PR here! I appreciate the PR with corrections, and also think the tool you're developing is very cool - but the format of the PR right now is a bit tough to review as a maintainer. Would you mind making the following changes? I'd be happy to review it after that:

Commits: We squash merge, so having multiple commits is fine here, but having a commit for each change makes it a lot harder to review individual changes. Would it be possible to rebase/squash these so that each commit contains all of the changes in a given directory (e.g. "docs", "script", "build", etc)? That would also let us identify more easily which typo changes could actually cause breaks - "docs" is unlikely to break anything, "build" more so. I'm also open to another way of organizing them if you'd like - but the goal is fewer, more clear commits.

PR Title: The title of the PR will be the text of your squashed commit - right now, that title isn't very descriptive. Could you change the title to be slightly more descriptive (appreciate the semantic commit at the beginning)

Once those two changes are made, I'll give this a proper review. Thanks for your time!

jsoref · 2022-06-15T15:54:42Z

@VerteDinde: happy to squash. I generally prefer to squash at the end as it makes it easier and safer for me to drop individual corrections if they are deemed objectionable.

The problematic commit if I squash by directories is:
8027a43

I'll just fold it in w/ that directory.

I'm happy to reword the PR title, although I don't have any particular ideas (I'm not particularly creative).

Anyway, squashed incoming...

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

VerteDinde · 2022-06-15T17:51:02Z

shell/browser/api/electron_api_system_preferences_win.cc

-  bool new_invertered_color_scheme = IsInvertedColorScheme();
-  if (new_invertered_color_scheme != invertered_color_scheme_) {
-    invertered_color_scheme_ = new_invertered_color_scheme;
-    Emit("inverted-color-scheme-changed", new_invertered_color_scheme);
+  bool new_inverted_color_scheme = IsInvertedColorScheme();
+  if (new_inverted_color_scheme != inverted_color_scheme_) {
+    inverted_color_scheme_ = new_inverted_color_scheme;
+    Emit("inverted-color-scheme-changed", new_inverted_color_scheme);


Just a note for future PRs: I'm generally fine with typo fixes in PRs when they deal with comments, docs, and tests.

Changing actual variables in code as part of a larger typo-fixing PR - when the rest of the PR doesn't directly deal with the corresponding code or explicitly fixing a bug - is riskier, and I'd really like to avoid doing that. These specific changes seem small and don't negatively impact the rest of the code, so I'm fine merging them with this PR, but this would likely be a merge blocker from me in the future.

welcome · 2022-06-16T07:46:13Z

Congrats on merging your first pull request! 🎉🎉🎉

release-clerk · 2022-06-16T07:46:15Z

No Release Notes

* chore: fix spelling in .circleci Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * chore: fix spelling in BUILD.gn Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * chore: fix spelling in appveyor.yml Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * chore: fix spelling in build Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * chore: fix spelling in docs Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * chore: fix spelling in lib Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * chore: fix spelling in script Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * chore: fix spelling in shell Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * chore: fix spelling in spec Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * chore: fix spelling in spec-main Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref requested a review from a team as a code owner June 15, 2022 01:21

electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 15, 2022

jsoref commented Jun 15, 2022

View reviewed changes

VerteDinde requested changes Jun 15, 2022

View reviewed changes

VerteDinde added semver/none no-backport labels Jun 15, 2022

jsoref added 10 commits June 15, 2022 12:05

chore: fix spelling in .circleci

7a67038

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

chore: fix spelling in BUILD.gn

bfbbbb6

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

chore: fix spelling in appveyor.yml

0fbaaaa

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

chore: fix spelling in build

b92f174

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

chore: fix spelling in docs

b4b11bc

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

chore: fix spelling in lib

bf2b8a3

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

chore: fix spelling in script

00225d9

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

chore: fix spelling in shell

c58956e

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

chore: fix spelling in spec

ca6966b

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

chore: fix spelling in spec-main

3c696bb

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref force-pushed the spelling branch from 9fc78e7 to 3c696bb Compare June 15, 2022 16:06

jsoref requested a review from VerteDinde June 15, 2022 17:39

VerteDinde reviewed Jun 15, 2022

View reviewed changes

VerteDinde changed the title ~~chore: Spelling~~ chore: fix spelling errors in multiple files Jun 15, 2022

VerteDinde approved these changes Jun 15, 2022

View reviewed changes

electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 16, 2022

zcbenz approved these changes Jun 16, 2022

View reviewed changes

zcbenz merged commit ea42787 into electron:main Jun 16, 2022

jsoref deleted the spelling branch June 16, 2022 11:56

commit-lint bot mentioned this pull request Aug 17, 2022

[pull] main from electron:main Blaquez-home/electron#3

Open

hmedo mentioned this pull request Oct 25, 2022

brand #36123

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: fix spelling errors in multiple files #34574

chore: fix spelling errors in multiple files #34574

jsoref commented Jun 15, 2022 •

edited by VerteDinde

Loading

jsoref left a comment

VerteDinde left a comment

jsoref commented Jun 15, 2022

VerteDinde Jun 15, 2022 •

edited

Loading

welcome bot commented Jun 16, 2022

release-clerk bot commented Jun 16, 2022

chore: fix spelling errors in multiple files #34574

chore: fix spelling errors in multiple files #34574

Conversation

jsoref commented Jun 15, 2022 • edited by VerteDinde Loading

Description of Change

Checklist

Release Notes

jsoref left a comment

Choose a reason for hiding this comment

VerteDinde left a comment

Choose a reason for hiding this comment

jsoref commented Jun 15, 2022

VerteDinde Jun 15, 2022 • edited Loading

Choose a reason for hiding this comment

welcome bot commented Jun 16, 2022

release-clerk bot commented Jun 16, 2022

jsoref commented Jun 15, 2022 •

edited by VerteDinde

Loading

VerteDinde Jun 15, 2022 •

edited

Loading