Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure that v8 sandbox isnt enabled for arm #35137

Merged
merged 1 commit into from Jul 29, 2022

Conversation

VerteDinde
Copy link
Member

Manual backport of #34914

See that PR for details

Notes: Fixes native module compilation issues on arm

@VerteDinde VerteDinde requested review from a team as code owners July 29, 2022 17:26
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 29, 2022
@trop trop bot added 20-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jul 29, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 29, 2022
@github-actions
Copy link
Contributor

electron-woa-testing

       2 files     904 suites   24m 1s ⏱️
2 115 tests 2 115 ✔️ 0 💤 0
2 403 runs  2 403 ✔️ 0 💤 0

Results for commit 29ecd69.

@jkleinsc jkleinsc merged commit 76450af into 20-x-y Jul 29, 2022
@jkleinsc jkleinsc deleted the backport-fix-native-modules-arm branch July 29, 2022 21:37
@release-clerk
Copy link

release-clerk bot commented Jul 29, 2022

Release Notes Persisted

Fixes native module compilation issues on arm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
20-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants