chore: remove UnresponsiveSuppressor altogether #35507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
zcbenz
approved these changes
Sep 8, 2022
There was a problem hiding this comment.
The UnresponsiveSuppressor was needed because the remote module was implemented with synchronous IPC messages that would hang the renderer, now since remote module has been removed and it is now totally user's responsibility to avoid hanging the renderer, I think UnresponsiveSuppressor is good to go.
|
No Release Notes |
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
* chore: drop unresponsive suppressor for menu_mac * also for views * header * chore: remove UnresponsiveSuppressor altogether
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
I think the reason this is not necessary is because when the main thread is
blocked, as it is in the cases guarded by UnresponsiveSuppressor here, then the
main thread cannot be processing any input events from renderers, and as such
can't come to the conclusion that a renderer is unresponsive. When we unblock
the main thread (e.g. by closing the message box or file dialog), then the
renderer is no longer unresponsive, so no event is generated.
As a practical matter, I've experimented with a couple of these removals and
haven't been able to create a situation where an unresponsive event is in fact
generated. Perhaps @zcbenz could help me to repro what this was originally
intended to fix? Chrome's implementation of unresponsiveness checking may have
changed in the intervening time.
Checklist
npm testpassesRelease Notes
Notes: none