-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cherry-pick 47968ed from chromium #35530
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
approved these changes
Sep 7, 2022
ckerr
approved these changes
Sep 13, 2022
Release Notes Persisted
|
trop bot
pushed a commit
that referenced
this pull request
Sep 15, 2022
Co-authored-by: Charles Kerr <charles@charleskerr.com>
I have automatically backported this PR to "19-x-y", please check out #35701 |
ckerr
added a commit
that referenced
this pull request
Sep 16, 2022
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-check-skip
Skip trop's backport validity checking
semver/minor
backwards-compatible functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject: dpwa: Enable Window Controls Overlay by default
This reverts commit d61c4042374672712176e43e33f39a1e66da4faa.
I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/guI1QCPJTAA
Bug: 937121
Change-Id: I3dfebec2356c7a12fd7eab32f12ef8d9e4bf6ee6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3430266
Commit-Queue: Alex Russell slightlyoff@chromium.org
Reviewed-by: Alex Russell slightlyoff@chromium.org
Reviewed-by: Avi Drissman avi@chromium.org
Cr-Commit-Position: refs/heads/main@{#1013665}
Closes #35214
main
and21-x-y
are passed105.0.5119.0
and therefore have this commitRelease Notes
Notes: Fixed an issue where a child of a window using WCO would not have the navigator defined