Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove no-op force-paint for hidden windows #35532

Merged
merged 3 commits into from
Sep 7, 2022
Merged

chore: remove no-op force-paint for hidden windows #35532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d12ffa
chore: remove no-op force-paint for hidden windows
nornagon Aug 31, 2022
97d5bd6
fix build
nornagon Sep 1, 2022
2ee07e7
Merge branch 'main' into remove-noop-forcepaint
nornagon Sep 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 0 additions & 11 deletions shell/browser/api/electron_api_browser_window.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,17 +158,6 @@ void BrowserWindow::RenderViewHostChanged(content::RenderViewHost* old_host,
new_host->GetWidget()->AddInputEventObserver(this);
}

void BrowserWindow::DidFirstVisuallyNonEmptyPaint() {
if (window()->IsClosed() || window()->IsVisible())
return;

// When there is a non-empty first paint, resize the RenderWidget to force
// Chromium to draw.
auto* const view = web_contents()->GetRenderWidgetHostView();
view->Show();
view->SetSize(window()->GetContentSize());
}

void BrowserWindow::BeforeUnloadDialogCancelled() {
WindowList::WindowCloseCancelled(window());
// Cancel unresponsive event when window close is cancelled.
Expand Down
1 change: 0 additions & 1 deletion shell/browser/api/electron_api_browser_window.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ class BrowserWindow : public BaseWindow,
// content::WebContentsObserver:
void RenderViewHostChanged(content::RenderViewHost* old_host,
content::RenderViewHost* new_host) override;
void DidFirstVisuallyNonEmptyPaint() override;
void BeforeUnloadDialogCancelled() override;
void OnRendererUnresponsive(content::RenderProcessHost*) override;
void OnRendererResponsive(
Expand Down