Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: exit properly when node-spec-runner validates specs #36091

Merged
merged 1 commit into from
Oct 21, 2022
Merged

test: exit properly when node-spec-runner validates specs #36091

merged 1 commit into from
Oct 21, 2022

Conversation

codebytere
Copy link
Member

Description of Change

Exit properly if node script/node-spec-runner --validateDisabled finds no missing tests.

Checklist

Release Notes

Notes: none

@codebytere codebytere added semver/none target/21-x-y PR should also be added to the "21-x-y" branch. target/22-x-y PR should also be added to the "22-x-y" branch. labels Oct 20, 2022
@codebytere codebytere changed the title test: exit properly when node spec runner validates specs test: exit properly when node-spec-runner validates specs Oct 20, 2022
@codebytere codebytere merged commit 3e730ab into main Oct 21, 2022
@codebytere codebytere deleted the exit-when-no-missing-node-specs branch October 21, 2022 09:14
@release-clerk
Copy link

release-clerk bot commented Oct 21, 2022

No Release Notes

This was referenced Oct 21, 2022
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Oct 21, 2022

I have automatically backported this PR to "22-x-y", please check out #36102

@trop trop bot added in-flight/22-x-y and removed target/22-x-y PR should also be added to the "22-x-y" branch. labels Oct 21, 2022
@trop
Copy link
Contributor

trop bot commented Oct 21, 2022

I have automatically backported this PR to "21-x-y", please check out #36103

@trop trop bot added in-flight/21-x-y merged/21-x-y PR was merged to the "21-x-y" branch. merged/22-x-y PR was merged to the "22-x-y" branch. and removed target/21-x-y PR should also be added to the "21-x-y" branch. in-flight/21-x-y labels Oct 21, 2022
@commit-lint commit-lint bot mentioned this pull request Feb 14, 2023
Open
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@codebytere @khalwa
test: exit properly when node-spec-runner validates specs (electron…
9ddeb70 
…#36091)

test: exit properly when node spec runner validates specs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees
No one assigned
Labels
merged/21-x-y PR was merged to the "21-x-y" branch. merged/22-x-y PR was merged to the "22-x-y" branch. semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @jkleinsc @VerteDinde