fix: linker error when enable_ppapi=false #36190
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
When building electron 21.2.0 on linux with gcc, no LTO and enable_plugins=false enable_ppapi=false, i'm getting a linker error at the very end (missing symbols).
The error does not happen when compiling with LTO, as all the references are in code that is dead when enable_ppapi=false.
This patch fixes the error for me.
Release Notes
none