Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 2611772cf0a0 from chromium #36517

Merged
merged 3 commits into from Dec 5, 2022

Conversation

MarshallOfSound
Copy link
Member

Add feature for window capturing with ScreenCaptureKit

Makes it possible to launch window capturing with
ScreenCaptureKit individually.

Bug: chromium:1352405
Change-Id: Ie58d15007667db887ebf5f6f3092ef323f925461
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4047186
Reviewed-by: Elad Alon eladalon@chromium.org
Commit-Queue: Johannes Kron kron@chromium.org
Cr-Commit-Position: refs/heads/main@{#1076120}

Notes: Backported fix for chromium:1352405.

@MarshallOfSound MarshallOfSound requested a review from a team as a code owner December 1, 2022 02:02
@MarshallOfSound MarshallOfSound added 22-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes labels Dec 1, 2022
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Dec 1, 2022
@nornagon
Copy link
Member

nornagon commented Dec 1, 2022

does this fix a bug?

@MarshallOfSound
Copy link
Member Author

does this fix a bug?

Not specifically, it lets folks test / roll out SCK for window capture specifically independently of full screen capture. (Useful for us)

@jkleinsc jkleinsc merged commit dcce07d into 22-x-y Dec 5, 2022
@jkleinsc jkleinsc deleted the cherry-pick/22-x-y/chromium/2611772cf0a0 branch December 5, 2022 17:06
@release-clerk
Copy link

release-clerk bot commented Dec 5, 2022

Release Notes Persisted

Backported fix for chromium:1352405.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
22-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants