Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 3235c1d1955b from chromium #36518

Merged
merged 2 commits into from Dec 1, 2022

Conversation

MarshallOfSound
Copy link
Member

Set visible_rect for streams captured with ScreenCaptureKit

This is needed to make the window capturing code on macOS
using the new ScreenCaptureKit API work, because the IOSurface
may be larger than the actual content resulting in garbage
unless the frame is cropped to |visible_rect|.

Bug: chromium:1352405
Change-Id: I1ce3c13947b9b4f9b75a071800a84a27a7c2ee4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4046582
Reviewed-by: Mark Foltz mfoltz@chromium.org
Commit-Queue: Johannes Kron kron@chromium.org
Reviewed-by: ccameron chromium ccameron@chromium.org
Reviewed-by: Ilya Nikolaevskiy ilnik@chromium.org
Reviewed-by: Will Cassella cassew@chromium.org
Cr-Commit-Position: refs/heads/main@{#1077752}

Notes: Backported fix for chromium:1352405.

@MarshallOfSound MarshallOfSound requested a review from a team as a code owner December 1, 2022 02:02
@MarshallOfSound MarshallOfSound added 22-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes labels Dec 1, 2022
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Dec 1, 2022
@MarshallOfSound MarshallOfSound merged commit 38eb414 into 22-x-y Dec 1, 2022
@MarshallOfSound MarshallOfSound deleted the cherry-pick/22-x-y/chromium/3235c1d1955b branch December 1, 2022 20:37
@release-clerk
Copy link

release-clerk bot commented Dec 1, 2022

Release Notes Persisted

Backported fix for chromium:1352405.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
22-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants