Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fixup mksnapshot args on linux #36531

Merged
merged 1 commit into from Dec 1, 2022
Merged

build: fixup mksnapshot args on linux #36531

merged 1 commit into from Dec 1, 2022

Conversation

jkleinsc
Copy link
Contributor

@jkleinsc jkleinsc commented Dec 1, 2022

Description of Change

Checklist

Release Notes

Notes: Removed unneeded --turbo-profiling-input argument from mksnapshot_args for Linux mksnapshot zips.

@jkleinsc jkleinsc added semver/patch backwards-compatible bug fixes target/21-x-y PR should also be added to the "21-x-y" branch. target/22-x-y PR should also be added to the "22-x-y" branch. target/23-x-y PR should also be added to the "23-x-y" branch. labels Dec 1, 2022
@jkleinsc jkleinsc merged commit 79d2fc9 into main Dec 1, 2022
@jkleinsc jkleinsc deleted the fixup-mksnapshot-args-linux branch December 1, 2022 19:12
@release-clerk
Copy link

release-clerk bot commented Dec 1, 2022

Release Notes Persisted

Removed unneeded --turbo-profiling-input argument from mksnapshot_args for Linux mksnapshot zips.

@trop trop bot mentioned this pull request Dec 1, 2022
Merged
@trop
Copy link
Contributor

trop bot commented Dec 1, 2022

I was unable to backport this PR to "21-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Dec 1, 2022

I was unable to backport this PR to "22-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/21-x-y and removed target/21-x-y PR should also be added to the "21-x-y" branch. target/22-x-y PR should also be added to the "22-x-y" branch. labels Dec 1, 2022
@trop
Copy link
Contributor

trop bot commented Dec 1, 2022

I have automatically backported this PR to "23-x-y", please check out #36534

@trop trop bot added needs-manual-bp/22-x-y in-flight/23-x-y merged/23-x-y PR was merged to the "23-x-y" branch. and removed target/23-x-y PR should also be added to the "23-x-y" branch. in-flight/23-x-y labels Dec 1, 2022
@LabhanshAgrawal
Copy link

Can you please backport it to v21, stuck at v20 without this. Thanks

@LabhanshAgrawal
Copy link

Can you please backport it to v21, stuck at v20 without this. Thanks

@jkleinsc @VerteDinde can guys please help with this. Thank you.

@VerteDinde
Copy link
Member

@LabhanshAgrawal The team is coming back in from a quiet period for December, I'll get this backported to v21 at the beginning of next week 🙇‍♀️

@LabhanshAgrawal
Copy link

Oh, my bad. Anyways, somehow 21.3.3 started working on CI for me this week, so no issue for me at the moment. Feel free to take a look once you guys are back.

@jkleinsc jkleinsc mentioned this pull request Jan 3, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Jan 3, 2023

@jkleinsc has manually backported this PR to "22-x-y", please check out #36782

@trop trop bot added the in-flight/22-x-y label Jan 3, 2023
@trop trop bot added merged/22-x-y PR was merged to the "22-x-y" branch. needs-manual-bp/21-x-y and removed in-flight/22-x-y labels Jan 5, 2023
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@jkleinsc @khalwa
build: fixup mksnapshot args on linux (electron#36531)
4a48b19
@commit-lint commit-lint bot mentioned this pull request Mar 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees
No one assigned
Labels
merged/22-x-y PR was merged to the "22-x-y" branch. merged/23-x-y PR was merged to the "23-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jkleinsc @LabhanshAgrawal @VerteDinde