fix: focus rings with multiple buttons in showMessageBox
#36772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
codebytere
changed the title
showMessageBox
codebytere
force-pushed
the
fix-highlighting
branch
from
5d96114
to
1c6ae2f
Compare
codebytere
force-pushed
the
fix-highlighting
branch
from
1c6ae2f
to
f726bc5
Compare
zcbenz
approved these changes
Jan 5, 2023
|
Release Notes Persisted
|
This was referenced Jan 5, 2023
|
I have automatically backported this PR to "21-x-y", please check out #36801 |
trop
bot
added
in-flight/21-x-y
and removed
target/21-x-y
|
I have automatically backported this PR to "22-x-y", please check out #36802 |
|
I have automatically backported this PR to "23-x-y", please check out #36803 |
trop
bot
added
in-flight/22-x-y
merged/21-x-y
trop
bot
added
merged/23-x-y
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
…36772) fix: focus rings with multiple buttons in messageBox
gecko19
pushed a commit
to brightsign/electron
that referenced
this pull request
Feb 28, 2023
…36772) fix: focus rings with multiple buttons in messageBox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #36721.
We shouldn't manually highlight the default button unless there's a cancel button with respective
cancelId. macOS automatically infers default button highlighting and changing that affects focus ring behavior and appearance.Before
After
Tested with https://gist.github.com/d9bd650ffc1efcf61016cbc81ea35652.
There's also another issue here with key equivalent accessibility, but i'm going to look into that as a follow-up.
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue with incorrect focus ring highlighting when using
dialog.showMessageBox().