-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: re-enable WindowCaptureMacV2 #37014
Conversation
2af42ae
to
24c7f1e
Compare
Test failures are related. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any tests that need to be re-enabled?
// TODO(deepak1556): Match upstream for `kWindowCaptureMacV2` | ||
#if 0 | ||
if (remote_cocoa::ScopedCGWindowID::Get(desktop_media_id.id)) { | ||
desktop_media_id.window_id = desktop_media_id.id; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change not needed with the feature enabled ? https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/media/webrtc/native_desktop_media_list.cc;l=770
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deepak1556 we could do this, but then it would be invalid when for example passed into getUserMedia.
I made this change for the same reason i did this one: https://github.com/electron/electron/pull/37014/files#diff-73f755a575b1c517f40cd8358386c43c4ffb0eff9e8a7a9ab80c5f50a248dcf4R156
b0af853
to
b227598
Compare
d9d2a22
to
4c6abd3
Compare
Description of Change
Refs #30507.
Per upstream CRBUG:1179098, issues have been fixed and is no longer reproducible when testing with https://gist.github.com/925744c7c67347d67c5b29e91c31e37e .
Checklist
npm test
passesRelease Notes
Notes: none