chore: re-enable worker spec failures #37015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
force-pushed
the
enable-test-worker-init-failure
branch
3 times, most recently
from
e4eb113
to
e98c95e
Compare
codebytere
force-pushed
the
enable-test-worker-init-failure
branch
from
e98c95e
to
43c1718
Compare
ckerr
approved these changes
Feb 9, 2023
|
No Release Notes |
trop bot
added a commit
that referenced
this pull request
Feb 13, 2023
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
trop bot
added a commit
that referenced
this pull request
Feb 13, 2023
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
codebytere
added a commit
that referenced
this pull request
Feb 15, 2023
* fix: cookies filter secure and session invalid Co-authored-by: Black-Hole1 <158blackhole@gmail.com> * test: add test Co-authored-by: Black-Hole1 <158blackhole@gmail.com> * test: fix test failed Co-authored-by: Black-Hole1 <158blackhole@gmail.com> * test: fix test failed again Co-authored-by: Black-Hole1 <158blackhole@gmail.com> * fix: session check logic incorrect Co-authored-by: Black-Hole1 <158blackhole@gmail.com> * refactor: reset cookies filter session logic Co-authored-by: Black-Hole1 <158blackhole@gmail.com> * Update shell/browser/api/electron_api_cookies.cc Co-authored-by: Robo <hop2deep@gmail.com> Co-authored-by: Black-Hole <158blackhole@gmail.com> * chore: re-enable worker spec failures (#37015) Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> --------- Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Black-Hole1 <158blackhole@gmail.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
gecko19
pushed a commit
to brightsign/electron
that referenced
this pull request
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Refs nodejs/node-v8#246.
Refs V8BUG:13493.
Upstream WASM stack switching issues appears to have been fixed, and no longer crashes locally. Re-enable tests accordingly.
Checklist
npm testpassesRelease Notes
Notes: none