-
Notifications
You must be signed in to change notification settings - Fork 15.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add BrowserWindow.set/getWindowButtonPosition APIs #37094
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron-cation
bot
added
new-pr 🌱
PR opened in the last 24 hours
api-review/requested 🗳
labels
Feb 1, 2023
zcbenz
force-pushed
the
deprecate-traffic-light-apis
branch
from
February 1, 2023 13:27
0a72024
to
f15f3f7
Compare
codebytere
reviewed
Feb 7, 2023
zcbenz
force-pushed
the
deprecate-traffic-light-apis
branch
from
February 9, 2023 10:52
f15f3f7
to
9095d5b
Compare
I have updated the code to properly deprecate the old APIs. |
codebytere
approved these changes
Feb 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API LGTM
nornagon
approved these changes
Feb 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API LGTM
electron-cation
bot
added
api-review/approved ✅
and removed
api-review/requested 🗳
labels
Feb 16, 2023
zcbenz
force-pushed
the
deprecate-traffic-light-apis
branch
from
February 17, 2023 08:03
9095d5b
to
13f6ec0
Compare
Release Notes Persisted
|
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
gecko19
pushed a commit
to brightsign/electron
that referenced
this pull request
Feb 28, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Close #34969.
This PR adds
BrowserWindow.set/getWindowButtonPosition
APIs which mean to replace theset/getTrafficLightPosition
that:null
instead of{ x: 0, y: 0 }
when there is no custom position;null
instead of{ x: 0, y: 0 }
to reset the position;set/getWindowButtonVisibility
APIs.Checklist
npm test
passesRelease Notes
Notes: Add BrowserWindow.set/getWindowButtonPosition APIs.