build: fix version check in release_dependency_versions.yml #37155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VerteDinde
approved these changes
Feb 7, 2023
codebytere
approved these changes
Feb 7, 2023
jkleinsc
approved these changes
Feb 7, 2023
|
Merging as CI failure unrelated to PR change. |
|
No Release Notes |
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
…#37155) * build: fix version check in release_dependency_versions.yml * chore: also mksnapshot
dsanders11
added
target/22-x-y
|
/trop run backport-to 22-x-y |
|
The backport process for this PR has been manually initiated - sending your PR to |
|
I was unable to backport this PR to "22-x-y" cleanly; |
trop
bot
added
needs-manual-bp/22-x-y
and removed
target/22-x-y
|
/trop run backport-to 23-x-y |
|
The backport process for this PR has been manually initiated - sending your PR to |
|
I was unable to backport this PR to "23-x-y" cleanly; |
trop
bot
added
needs-manual-bp/23-x-y
and removed
target/23-x-y
gecko19
pushed a commit
to brightsign/electron
that referenced
this pull request
Feb 28, 2023
…#37155) * build: fix version check in release_dependency_versions.yml * chore: also mksnapshot
dsanders11
added
no-backport
and removed
needs-manual-bp/22-x-y
needs-manual-bp/23-x-y
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Turns out
\disn't supported in POSIX regexes - could use[:digit:]but personally I just prefer[0-9]here.Example of skipped dependencies for
v23.0.0: https://github.com/electron/electron/actions/runs/4109277828/jobs/7090932840Checklist
Release Notes
Notes: none