-
Notifications
You must be signed in to change notification settings - Fork 15.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add httpOnly
cookies.get
filter
#37255
feat: add httpOnly
cookies.get
filter
#37255
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API LGTM
Given we allow setting cookies with an httpOnly
filter, it seems reasonable to allow the same in the getter.
httpOnly
cookies filter
httpOnly
cookies filterhttpOnly
cookies.get
filter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API LGTM
Release Notes Persisted
|
I was unable to backport this PR to "23-x-y" cleanly; |
I have automatically backported this PR to "24-x-y", please check out #37365 |
feat: add httpOnly cookies filter
feat: add httpOnly cookies filter
feat: add httpOnly cookies filter
@BlackHole1 has manually backported this PR to "23-x-y", please check out #38043 |
Description of Change
The existing filter does not fully cover some scenarios, such as
httpOnly
. ThishttpOnly
filter can avoid additional judgments at the js level.Checklist
npm test
passesRelease Notes
Notes: Add
httpOnly
to the cookie filter.