Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use webContents.create() in type-safe way #37281

Merged
merged 1 commit into from Feb 16, 2023
Merged

test: use webContents.create() in type-safe way #37281

merged 1 commit into from Feb 16, 2023

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Feb 15, 2023

Description of Change

Improves type safety

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are changed or added

Release Notes

Notes: none

@miniak miniak changed the title test: use (webContents as typeof ElectronInternal.WebContents).create() test: use webContents.create() in type-safe way Feb 15, 2023
@miniak miniak added target/22-x-y PR should also be added to the "22-x-y" branch. target/23-x-y PR should also be added to the "23-x-y" branch. target/24-x-y PR should also be added to the "24-x-y" branch. and removed target/22-x-y PR should also be added to the "22-x-y" branch. target/23-x-y PR should also be added to the "23-x-y" branch. labels Feb 15, 2023
@miniak miniak self-assigned this Feb 15, 2023
@deepak1556
Copy link
Member

Can you resolve the conflicts, thanks!

@miniak
Copy link
Contributor Author

miniak commented Feb 16, 2023

@deepak1556 done

@codebytere codebytere merged commit ea848bc into main Feb 16, 2023
@codebytere codebytere deleted the miniak/web-contents-create branch February 16, 2023 14:41
@release-clerk
Copy link

release-clerk bot commented Feb 16, 2023

No Release Notes

@trop trop bot mentioned this pull request Feb 16, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Feb 16, 2023

I have automatically backported this PR to "24-x-y", please check out #37308

@trop trop bot added in-flight/24-x-y merged/24-x-y PR was merged to the "24-x-y" branch and removed target/24-x-y PR should also be added to the "24-x-y" branch. in-flight/24-x-y labels Feb 16, 2023
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@miniak @khalwa
test: use webContents.create() in type-safe way (electron#37281)
c9f6e10 
test: use (webContents as typeof ElectronInternal.WebContents).create()

Co-authored-by: Milan Burda <miburda@microsoft.com>
gecko19 pushed a commit to brightsign/electron that referenced this pull request Feb 28, 2023
@miniak @gecko19
test: use webContents.create() in type-safe way (electron#37281)
06c5056 
test: use (webContents as typeof ElectronInternal.WebContents).create()

Co-authored-by: Milan Burda <miburda@microsoft.com>
@commit-lint commit-lint bot mentioned this pull request May 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@codebytere codebytere codebytere approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees

@miniak miniak

Labels
merged/24-x-y PR was merged to the "24-x-y" branch semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@miniak @deepak1556 @codebytere @VerteDinde