Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: use node 18.12 in AppVeyor (22-x-y) #37284

Merged
merged 2 commits into from
Feb 16, 2023
Merged

build: use node 18.12 in AppVeyor (22-x-y) #37284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c63bde
build: use node18.12 appveyor image
VerteDinde Feb 15, 2023
423bbea
build: use e-108.0.5359.215-node18
VerteDinde Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion appveyor-bake.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

version: 1.0.{build}
build_cloud: electronhq-16-core
image: e-111.0.5560.0-2
image: e-111.0.5560.0-node18
environment:
GIT_CACHE_PATH: C:\Users\appveyor\libcc_cache
ELECTRON_OUT_DIR: Default
Expand Down
2 changes: 1 addition & 1 deletion appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@

version: 1.0.{build}
build_cloud: electronhq-16-core
image: e-108.0.5359.215
image: e-108.0.5359.215-node18
environment:
GIT_CACHE_PATH: C:\Users\appveyor\libcc_cache
ELECTRON_OUT_DIR: Default
Expand Down
4 changes: 2 additions & 2 deletions script/prepare-appveyor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ const ROLLER_BRANCH_PATTERN = /^roller\/chromium$/;

const DEFAULT_BUILD_CLOUD_ID = '1598';
const DEFAULT_BUILD_CLOUD = 'electronhq-16-core';
const DEFAULT_BAKE_BASE_IMAGE = 'e-111.0.5560.0-2';
const DEFAULT_BUILD_IMAGE = 'e-111.0.5560.0-2';
const DEFAULT_BAKE_BASE_IMAGE = 'e-111.0.5560.0-node18';
const DEFAULT_BUILD_IMAGE = 'e-111.0.5560.0-node18';

const appveyorBakeJob = 'electron-bake-image';
const appVeyorJobs = {
Expand Down
3 changes: 2 additions & 1 deletion script/setup-win-for-dev.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ REM Install Windows SDK
choco install windows-sdk-10-version-2104-all

REM Install nodejs python git and yarn needed dependencies
choco install -y nodejs-lts python2 git yarn
choco install -y --force nodejs --version=18.12.1
choco install -y python2 git yarn
choco install python --version 3.7.9
call C:\ProgramData\chocolatey\bin\RefreshEnv.cmd
SET PATH=C:\Python27\;C:\Python27\Scripts;C:\Python39\;C:\Python39\Scripts;%PATH%
Expand Down