-
Notifications
You must be signed in to change notification settings - Fork 15.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve contents.takeHeapSnapshot
error messages
#37434
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
backwards-compatible bug fixes
22-x-y
target/23-x-y
PR should also be added to the "23-x-y" branch.
target/24-x-y
PR should also be added to the "24-x-y" branch.
labels
Feb 28, 2023
codebytere
force-pushed
the
improve-takeheapsnapshot-errors
branch
2 times, most recently
from
February 28, 2023 14:44
03a1711
to
fb65494
Compare
codebytere
force-pushed
the
improve-takeheapsnapshot-errors
branch
from
March 1, 2023 08:57
fb65494
to
97fb422
Compare
jkleinsc
approved these changes
Mar 1, 2023
codebytere
added
target/22-x-y
PR should also be added to the "22-x-y" branch.
and removed
22-x-y
labels
Mar 1, 2023
Release Notes Persisted
|
This was referenced Mar 1, 2023
I have automatically backported this PR to "22-x-y", please check out #37459 |
I have automatically backported this PR to "23-x-y", please check out #37460 |
trop
bot
added
in-flight/22-x-y
and removed
target/22-x-y
PR should also be added to the "22-x-y" branch.
target/23-x-y
PR should also be added to the "23-x-y" branch.
labels
Mar 1, 2023
I have automatically backported this PR to "24-x-y", please check out #37461 |
trop
bot
added
in-flight/24-x-y
merged/23-x-y
PR was merged to the "23-x-y" branch.
merged/24-x-y
PR was merged to the "24-x-y" branch
merged/22-x-y
PR was merged to the "22-x-y" branch.
and removed
target/24-x-y
PR should also be added to the "24-x-y" branch.
in-flight/23-x-y
labels
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
merged/22-x-y
PR was merged to the "22-x-y" branch.
merged/23-x-y
PR was merged to the "23-x-y" branch.
merged/24-x-y
PR was merged to the "24-x-y" branch
semver/patch
backwards-compatible bug fixes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #37424.
Adds more descriptive error messages to
contents.takeHeapSnapshot
so that users better understand why it may have failed.Checklist
npm test
passesRelease Notes
Notes: Improved error messages for
contents.takeHeapSnapshot
.