New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: updated package.json content and electron version in build first app guide #37554
Conversation
💖 Thanks for opening this pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I think we recommend using exact versions too so we should make the version numbers not use the caret. :)
@erickzhao thanks for the comment :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs: lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving on behalf of the Electron Docs Team
Congrats on merging your first pull request! 🎉🎉🎉 |
No Release Notes |
I have automatically backported this PR to "23-x-y", please check out #37742 |
I have automatically backported this PR to "24-x-y", please check out #37743 |
Description of Change
The Building your First App guide states: "Your package.json file should look something like this after initializing your package and installing Electron." then
package.json
content is shown, but it is not up to date with how it looks now when creating the app by using the commands provided in the guide and the default values. This was corrected by adding:which is added by default while
npm init
. Also bumped the electron version.Checklist
Release Notes
notes: no-notes