fix: allow cancelling of bluetooth requests #37601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allows cancelling of bluetooth requests when no devices present
jkleinsc
added
semver/patch
electron-cation
bot
added
new-pr 🌱
3 tasks
VerteDinde
approved these changes
Mar 22, 2023
|
Release Notes Persisted
|
|
I was unable to backport this PR to "23-x-y" cleanly; |
|
I was unable to backport this PR to "22-x-y" cleanly; |
trop
bot
added
needs-manual-bp/23-x-y
and removed
target/23-x-y
|
I have automatically backported this PR to "24-x-y", please check out #37717 |
trop
bot
added
in-flight/24-x-y
merged/24-x-y
jkleinsc
added a commit
that referenced
this pull request
Mar 27, 2023
* fix: allow cancelling of bluetooth requests allows cancelling of bluetooth requests when no devices present * docs: update docs to reflect how bluetooth works. (cherry picked from commit 6a6908c)
jkleinsc
added a commit
that referenced
this pull request
Mar 27, 2023
(cherry picked from commit 6a6908c)
jkleinsc
added a commit
that referenced
this pull request
Mar 28, 2023
trop bot
added a commit
that referenced
this pull request
Mar 28, 2023
(cherry picked from commit 6a6908c) Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
trop
bot
added
in-flight/22-x-y
merged/22-x-y
codebytere
pushed a commit
that referenced
this pull request
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
There was an issue where bluetooth requests could not be cancelled when no devices are returned because
select-bluetooth-devicenever fires in that case and the only way to cancel a bluetooth request is to call the callback fromselect-bluetooth-devicewith an empty string. This PR fixes that issue by always firingselect-bluetooth-deviceregardless of whether devices are available or not.Additionally, this PR updates the bluetooth documentation to be more accurate and contain more explanation about how
select-bluetooth-deviceworks as well as to update the example fiddle to include logic to cancel a bluetooth request.Checklist
npm testpassesRelease Notes
Notes: Fixed canceling of bluetooth requests when no devices are returned.