Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: change MSDN links to new Microsoft docs #37603

Merged
merged 1 commit into from Mar 21, 2023
Merged

docs: change MSDN links to new Microsoft docs #37603

merged 1 commit into from Mar 21, 2023

Conversation

erickzhao
Copy link
Member

Description of Change

MSDN was shut down and merged into https://learn.microsoft.com in 2020. I dug through all the links in our docs and followed the redirects.

In some cases, we got redirected to the home page. I think I was able to find all the matching docs based on searches in https://web.archive.org.

Note that there are a few stragglers in code comments but I think we should change those links in a separate PR so this PR can count as docs-only.

cc @electron/docs

Checklist

Release Notes

Notes: none

@electron-cation electron-cation bot added documentation 📓 semver/patch backwards-compatible bug fixes new-pr 🌱 PR opened in the last 24 hours labels Mar 16, 2023
@erickzhao erickzhao added target/23-x-y PR should also be added to the "23-x-y" branch. target/24-x-y PR should also be added to the "24-x-y" branch. labels Mar 16, 2023
dsanders11
dsanders11 approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's nice that the learn.microsoft.com links actually have meaningful URLs, makes it a lot easier to spot check correctness. 🙂

@dsanders11
Copy link
Member

Not sure if you want to do it in this PR as well, but it looks like docs.microsoft.com was also merged into learn.microsoft.com, so those links could be rewritten as well.

FYI, yarn run lint:docs-relative-links --fetch-external-links --check-redirects will show you all the redirects in the docs currently, and the final URL after redirection.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 17, 2023
@jkleinsc jkleinsc merged commit 2ac9ff1 into electron:main Mar 21, 2023
11 checks passed
@release-clerk
Copy link

release-clerk bot commented Mar 21, 2023

No Release Notes

@trop
Copy link
Contributor

trop bot commented Mar 21, 2023

I was unable to backport this PR to "23-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/23-x-y PR should also be added to the "23-x-y" branch. label Mar 21, 2023
@trop
Copy link
Contributor

trop bot commented Mar 21, 2023

I was unable to backport this PR to "24-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/23-x-y needs-manual-bp/24-x-y and removed target/24-x-y PR should also be added to the "24-x-y" branch. labels Mar 21, 2023
@dsanders11
Copy link
Member

/trop run backport-to 24-x-y,23-x-y

@trop
Copy link
Contributor

trop bot commented Mar 23, 2023

The backport process for this PR has been manually initiated - sending your PR to 24-x-y!

@trop
Copy link
Contributor

trop bot commented Mar 23, 2023

The backport process for this PR has been manually initiated - sending your PR to 23-x-y!

@trop
Copy link
Contributor

trop bot commented Mar 23, 2023

I was unable to backport this PR to "24-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Mar 23, 2023

I was unable to backport this PR to "23-x-y" cleanly;
you will need to perform this backport manually.

@dsanders11 dsanders11 added target/24-x-y PR should also be added to the "24-x-y" branch. and removed needs-manual-bp/24-x-y labels Mar 23, 2023
@dsanders11
Copy link
Member

/trop run backport-to 24-x-y

@trop
Copy link
Contributor

trop bot commented Mar 24, 2023

The backport process for this PR has been manually initiated - sending your PR to 24-x-y!

@trop
Copy link
Contributor

trop bot commented Mar 24, 2023

I was unable to backport this PR to "24-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/24-x-y and removed target/24-x-y PR should also be added to the "24-x-y" branch. labels Mar 24, 2023
@dsanders11 dsanders11 mentioned this pull request Mar 24, 2023
Merged
@dsanders11
Copy link
Member

/trop run backport-to 24-x-y

@trop
Copy link
Contributor

trop bot commented Mar 24, 2023

The backport process for this PR has been manually initiated - sending your PR to 24-x-y!

@trop trop bot mentioned this pull request Mar 24, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Mar 24, 2023

I have automatically backported this PR to "24-x-y", please check out #37703

@dsanders11
Copy link
Member

For future reference, all the noise in these comments was to track down a trop bug.

@dsanders11 dsanders11 mentioned this pull request Mar 24, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Mar 24, 2023

@dsanders11 has manually backported this PR to "23-x-y", please check out #37706

@dsanders11 dsanders11 mentioned this pull request Mar 24, 2023
Merged
1 task
@trop trop bot added merged/23-x-y PR was merged to the "23-x-y" branch. merged/24-x-y PR was merged to the "24-x-y" branch and removed in-flight/23-x-y labels Mar 27, 2023
@commit-lint commit-lint bot mentioned this pull request Jun 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VerteDinde VerteDinde VerteDinde approved these changes

@dsanders11 dsanders11 dsanders11 approved these changes

Assignees
No one assigned
Labels
documentation 📓 merged/23-x-y PR was merged to the "23-x-y" branch. merged/24-x-y PR was merged to the "24-x-y" branch semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@erickzhao @dsanders11 @VerteDinde @jkleinsc