fix: set background color for menu bar on Windows #37766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsanders11
added
23-x-y
24-x-y
semver/patch
codebytere
approved these changes
Mar 30, 2023
|
Release Notes Persisted
|
This was referenced Mar 31, 2023
|
I have automatically backported this PR to "23-x-y", please check out #37784 |
trop
bot
added
in-flight/23-x-y
and removed
target/23-x-y
|
I have automatically backported this PR to "24-x-y", please check out #37785 |
trop
bot
added
in-flight/24-x-y
and removed
target/24-x-y
trop
bot
added
merged/24-x-y
|
@GhostlyDark has manually backported this PR to "22-x-y", please check out #37991 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #34939.
More information is in a comment on that issue, but the long and short of it is the
Backgroundcreated byviews::CreateThemedSolidBackgroundisn't immediately set, and will change to stay in sync with the color provider. So the code has been refactored to ensurebackground_color_is always up-to-date.Checklist
npm testpassesRelease Notes
Notes: Fixed the active background color for top-level menu items on Windows