fix: set background color for menu bar on Windows #37766
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #34939.
More information is in a comment on that issue, but the long and short of it is the
Background
created byviews::CreateThemedSolidBackground
isn't immediately set, and will change to stay in sync with the color provider. So the code has been refactored to ensurebackground_color_
is always up-to-date.Checklist
npm test
passesRelease Notes
Notes: Fixed the active background color for top-level menu items on Windows