fix: Fn+F fullscreen transitioning on macOS #37803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
codebytere
force-pushed
the
fix-fullscreen-double-send
branch
from
4a1ef03
to
07c27c3
Compare
zcbenz
reviewed
Apr 4, 2023
codebytere
force-pushed
the
fix-fullscreen-double-send
branch
from
07c27c3
to
6717ff0
Compare
zcbenz
approved these changes
Apr 4, 2023
|
Release Notes Persisted
|
This was referenced Apr 4, 2023
|
I have automatically backported this PR to "23-x-y", please check out #37822 |
|
I have automatically backported this PR to "24-x-y", please check out #37823 |
trop
bot
added
in-flight/24-x-y
merged/23-x-y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #37761.
Fixes an issue on macOS where entering fullscreen with the
Fn+Fsystem shortcut would fail or create strange window side effects. This was happening as a result of https://chromium-review.googlesource.com/c/chromium/src/+/3496322, which changed the logic incontent/app_shim_remote_cocoa/render_widget_host_view_cocoa.mmto sent the keyboard shortcut directly to theNSMenuinstance if the keyboard event is a system shortcut.In combination with our own logic in
WebContents::PlatformHandleKeyboardEvent, this meant that the BrowserWindow would be incorrectly sent two calls totoggleFullScreenMode. We prevent this by ensuring that system keyboard shortcuts are only sent to theNSMenuinstance once.Checklist
npm testpassesRelease Notes
Notes: Fixes an issue on macOS where entering fullscreen with the
Fn+Fsystem shortcut would fail or create strange window side effects.