Commits on Apr 10, 2023

1. fix: recommended node-gyp version in node.h error …

   In
   https://github.com/electron/electron/blob/main/docs/tutorial/using-native-node-modules.md#using-npm,
   we recommend setting the `npm_config_disturl` variable but doing that
   does not work on node-gyp v8.4.0 because after
   nodejs/node-gyp#2497
   landed, the dist URL was read only from `gyp.opts['dist-url']`. The fix
   for reading the value from `npm_config_disturl` by parsing
   `gyp.opts.disturl` was landed in
   nodejs/node-gyp#2547 and that change was
   released in node-gyp v9.0.0, so this change updates the error macro to
   recommend node-gyp v9.0.0 as the minimum required version.
   
   Signed-off-by: Darshan Sen <raisinten@gmail.com>

   

   RaisinTen committed Apr 10, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 120cfad
   • Browse repository at this point

   Copy the full SHA

   120cfad View commit details

   Browse the repository at this point in the history