chore: bump node to v18.16.0 (main) #37973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![electron-roller[bot]](https://avatars.githubusercontent.com/in/115177?s=60&v=4){kind=small}
electron-roller
bot
added
no-backport
semver/patch
electron-cation
bot
added
new-pr 🌱
codebytere
force-pushed
the
roller/node/main
branch
2 times, most recently
from
03f68fc
to
60b2a8f
Compare
codebytere
force-pushed
the
roller/node/main
branch
3 times, most recently
from
6b325be
to
bdb5238
Compare
codebytere
force-pushed
the
roller/node/main
branch
from
64e54ff
to
3e0eb41
Compare
VerteDinde
approved these changes
Apr 18, 2023
|
Release Notes Persisted
|
nornagon
reviewed
Apr 18, 2023
| // true to this function instead of the original string. Any other string | ||
| // value will be interpreted as custom DH parameters below. | ||
| +#ifndef OPENSSL_IS_BORINGSSL | ||
| if (args[0]->IsTrue()) { |
There was a problem hiding this comment.
should we throw or otherwise fail more noisily here? if we don't implement the "auto" setting, but the client requests it, what do we do?
|
Is there a reason this is marked for no backport? This would be nice to have in electron 25 at least since this fixes some security vulnerabilities in c-ares. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating Node.js to v18.16.0.
See all changes in v18.15.0..v18.16.0
Notes: Updated Node.js to v18.16.0.