fix: webContents return type incorrect #38026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
approved these changes
Apr 19, 2023
codebytere
added
semver/patch
codebytere
reviewed
Apr 19, 2023
There was a problem hiding this comment.
@BlackHole1 you'll need to update some tests in order to account for new possible null webContents values;
An error occurred while running the spec runner
electron/spec/api-web-contents-spec.ts(495,14): error TS2531: Object is possibly 'null'.
electron/spec/api-web-contents-spec.ts(500,14): error TS2531: Object is possibly 'null'.
electron/spec/api-web-contents-spec.ts(504,14): error TS2531: Object is possibly 'null'.
|
@BlackHole1, another failing test: |
|
@dsanders11 I fixed this issue locally before leaving work, but I forgot to push it 🤣 I'll update it when I come back to work tomorrow. |
BlackHole1
force-pushed
the
fix-webContents-type
branch
from
1142052
to
bfa12f7
Compare
BlackHole1
force-pushed
the
fix-webContents-type
branch
from
bfa12f7
to
62526bf
Compare
|
Ci failure has nothing to do with the current PR |
dsanders11
approved these changes
Apr 20, 2023
jkleinsc
approved these changes
Apr 24, 2023
|
No Release Notes |
|
I was unable to backport this PR to "24-x-y" cleanly; |
|
I was unable to backport this PR to "23-x-y" cleanly; |
trop
bot
added
needs-manual-bp/24-x-y
needs-manual-bp/23-x-y
and removed
target/24-x-y
|
I have automatically backported this PR to "25-x-y", please check out #38107 |
trop
bot
added
in-flight/25-x-y
and removed
target/25-x-y
BlackHole1
added a commit
to BlackHole1/electron
that referenced
this pull request
Apr 25, 2023
* fix: webContents type incorrect * fix: ci failed * fix: ci failed 2
|
@BlackHole1 has manually backported this PR to "24-x-y", please check out #38111 |
BlackHole1
added a commit
to BlackHole1/electron
that referenced
this pull request
Apr 25, 2023
* fix: webContents type incorrect * fix: ci failed * fix: ci failed 2
|
@BlackHole1 has manually backported this PR to "23-x-y", please check out #38112 |
trop
bot
added
in-flight/23-x-y
merged/25-x-y
codebytere
pushed a commit
that referenced
this pull request
Apr 25, 2023
fix: webContents return type incorrect (#38026) * fix: webContents type incorrect * fix: ci failed * fix: ci failed 2
codebytere
pushed a commit
that referenced
this pull request
Apr 25, 2023
fix: webContents return type incorrect (#38026) * fix: webContents type incorrect * fix: ci failed * fix: ci failed 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Some APIs may have undefined return values, but they are not reflected in d.ts.
Before:
After:
Checklist
npm testpassesRelease Notes
Notes: none