Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick f58218891f8c from chromium #38056

Merged
merged 2 commits into from Apr 25, 2023

Conversation

ppontes
Copy link
Member

@ppontes ppontes commented Apr 21, 2023

[M112] Stop supporting { handleEvent }.

Make the code aligned with the following specification update:
w3c/ServiceWorker#1676

With the previous specification and code, event listener vector
can be modified during the GetEffectiveFunction execution, which may
bring unexpected vector state.

(cherry picked from commit 5105ce37a6853d52ec97894bf6969b3c29a23afd)

Change-Id: I732c4c9ab2caebc49a7f4ef52640df7b8476d838
Bug: 1429201
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4394402
Commit-Queue: Yoshisato Yanagisawa yyanagisawa@chromium.org
Reviewed-by: Kouhei Ueno kouhei@chromium.org
Reviewed-by: Domenic Denicola domenic@chromium.org
Cr-Original-Commit-Position: refs/heads/main@{#1126483}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4408837
Reviewed-by: Shunya Shishido sisidovski@chromium.org
Reviewed-by: Minoru Chikamune chikamune@chromium.org
Cr-Commit-Position: refs/branch-heads/5615@{#1203}
Cr-Branched-From: 9c6408ef696e83a9936b82bbead3d41c93c82ee4-refs/heads/main@{#1109224}

Ref electron/security#313

Notes: Security: backported fix for CVE-2023-2134.

@ppontes ppontes requested a review from a team as a code owner April 21, 2023 14:09
@ppontes ppontes added security 🔒 semver/patch backwards-compatible bug fixes backport-check-skip Skip trop's backport validity checking 22-x-y labels Apr 21, 2023
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Apr 21, 2023
@ppontes ppontes marked this pull request as draft April 21, 2023 14:09
@ppontes ppontes force-pushed the cherry-pick/22-x-y/chromium/f58218891f8c branch from b29d5ca to f489c16 Compare April 21, 2023 22:04
@ppontes ppontes force-pushed the cherry-pick/22-x-y/chromium/f58218891f8c branch from f489c16 to ccc08af Compare April 24, 2023 13:55
@ppontes ppontes marked this pull request as ready for review April 24, 2023 13:55
@codebytere codebytere merged commit f907c18 into 22-x-y Apr 25, 2023
13 checks passed
@codebytere codebytere deleted the cherry-pick/22-x-y/chromium/f58218891f8c branch April 25, 2023 09:45
@release-clerk
Copy link

release-clerk bot commented Apr 25, 2023

Release Notes Persisted

Security: backported fix for CVE-2023-2134.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
22-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants