Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: defaults broken in shell.openExternal() options #38092

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Apr 23, 2023

Backport of #38038

See that PR for details.

Notes: Fixed broken defaults in shell.openExternal() options.

Co-authored-by: Milan Burda <miburda@microsoft.com>
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 23, 2023
@trop trop bot added 22-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Apr 23, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 23, 2023
@miniak miniak changed the title fix: defaults broken in shell.openExternal() options (#38038) fix: defaults broken in shell.openExternal() options Apr 23, 2023
@codebytere codebytere merged commit 2757556 into 22-x-y Apr 24, 2023
@codebytere codebytere deleted the miniak/fix-shell-open-external-options-22-x-y branch April 24, 2023 13:25
@release-clerk
Copy link

release-clerk bot commented Apr 24, 2023

Release Notes Persisted

Fixed broken defaults in shell.openExternal() options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
22-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants