Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable BrowserWindow.id access post-destruction #38241

Merged
merged 1 commit into from
May 16, 2023
Merged

fix: enable BrowserWindow.id access post-destruction #38241

merged 1 commit into from
May 16, 2023

Conversation

codebytere
Copy link
Member

Description of Change

Closes #38170.

Enable access to BrowserWindow.id after the window has been destroyed.

Checklist

Release Notes

Notes: Fixed an issue where accessing BrowserWindow.id threw an error after the window was destroyed.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/23-x-y PR should also be added to the "23-x-y" branch. target/24-x-y PR should also be added to the "24-x-y" branch. target/25-x-y PR should also be added to the "25-x-y" branch. labels May 10, 2023
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels May 10, 2023
@miniak
Copy link
Contributor

miniak commented May 13, 2023

Similar to #27038

@codebytere codebytere merged commit 9bd9d31 into main May 16, 2023
12 of 13 checks passed
@codebytere codebytere deleted the bw-id-after-destroy branch May 16, 2023 07:29
@release-clerk
Copy link

release-clerk bot commented May 16, 2023

Release Notes Persisted

Fixed an issue where accessing BrowserWindow.id threw an error after the window was destroyed.

@trop trop bot mentioned this pull request May 16, 2023
Merged
@trop
Copy link
Contributor

trop bot commented May 16, 2023

I have automatically backported this PR to "23-x-y", please check out #38309

@trop trop bot mentioned this pull request May 16, 2023
Merged
@trop trop bot removed the target/23-x-y PR should also be added to the "23-x-y" branch. label May 16, 2023
@trop trop bot mentioned this pull request May 16, 2023
Merged
@trop
Copy link
Contributor

trop bot commented May 16, 2023

I have automatically backported this PR to "24-x-y", please check out #38310

@trop
Copy link
Contributor

trop bot commented May 16, 2023

I have automatically backported this PR to "25-x-y", please check out #38311

@trop trop bot added in-flight/24-x-y in-flight/25-x-y merged/25-x-y PR was merged to the "25-x-y" branch. and removed target/24-x-y PR should also be added to the "24-x-y" branch. target/25-x-y PR should also be added to the "25-x-y" branch. labels May 16, 2023
@trop trop bot added merged/24-x-y PR was merged to the "24-x-y" branch merged/23-x-y PR was merged to the "23-x-y" branch. and removed in-flight/25-x-y in-flight/24-x-y labels May 16, 2023
@theolivenbaum theolivenbaum mentioned this pull request Jun 2, 2023
Closed
@commit-lint commit-lint bot mentioned this pull request Aug 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniak miniak miniak approved these changes

@jkleinsc jkleinsc Awaiting requested review from jkleinsc

@zcbenz zcbenz Awaiting requested review from zcbenz

@deepak1556 deepak1556 Awaiting requested review from deepak1556

Assignees
No one assigned
Labels
merged/23-x-y PR was merged to the "23-x-y" branch. merged/24-x-y PR was merged to the "24-x-y" branch merged/25-x-y PR was merged to the "25-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Accessing BrowserWindow.id throws an error after the window is closed/destroyed
2 participants
@codebytere @miniak