Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: ensure app.md examples are runnable #38416

Merged
merged 1 commit into from
May 24, 2023
Merged

docs: ensure app.md examples are runnable #38416

merged 1 commit into from
May 24, 2023

Conversation

codebytere
Copy link
Member

Description of Change

Tweak code samples in app.md so that they're minimally runnable.

Checklist

Release Notes

Notes: none

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/24-x-y PR should also be added to the "24-x-y" branch. target/25-x-y PR should also be added to the "25-x-y" branch. labels May 23, 2023
@electron-cation electron-cation bot added documentation 📓 new-pr 🌱 PR opened in the last 24 hours labels May 23, 2023
erickzhao
erickzhao approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs: lgtm

electron-docs-reviewer[bot]
electron-docs-reviewer bot approved these changes May 23, 2023
View reviewed changes
Copy link

@electron-docs-reviewer electron-docs-reviewer bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on behalf of the Electron Docs Team

@dsanders11 dsanders11 mentioned this pull request May 24, 2023
Merged
1 task
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 24, 2023
@jkleinsc jkleinsc merged commit ec85be3 into main May 24, 2023
16 checks passed
@jkleinsc jkleinsc deleted the app-docs-runnable branch May 24, 2023 20:41
@release-clerk
Copy link

release-clerk bot commented May 24, 2023

No Release Notes

This was referenced May 24, 2023
Merged
Merged
@trop
Copy link
Contributor

trop bot commented May 24, 2023

I have automatically backported this PR to "24-x-y", please check out #38439

@trop trop bot added in-flight/24-x-y and removed target/24-x-y PR should also be added to the "24-x-y" branch. labels May 24, 2023
@trop
Copy link
Contributor

trop bot commented May 24, 2023

I have automatically backported this PR to "25-x-y", please check out #38440

@trop trop bot added in-flight/25-x-y merged/24-x-y PR was merged to the "24-x-y" branch merged/25-x-y PR was merged to the "25-x-y" branch. and removed target/25-x-y PR should also be added to the "25-x-y" branch. in-flight/24-x-y in-flight/25-x-y labels May 24, 2023
@commit-lint commit-lint bot mentioned this pull request Aug 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@dsanders11 dsanders11 dsanders11 approved these changes

@erickzhao erickzhao erickzhao approved these changes

@electron-docs-reviewer electron-docs-reviewer[bot] electron-docs-reviewer approved these changes

Assignees
No one assigned
Labels
documentation 📓 merged/24-x-y PR was merged to the "24-x-y" branch merged/25-x-y PR was merged to the "25-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@codebytere @jkleinsc @dsanders11 @erickzhao