Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: remove V8 patch for ArrayBuffer DCHECK #38591

Merged
merged 1 commit into from
Jun 6, 2023
Merged

build: remove V8 patch for ArrayBuffer DCHECK #38591

merged 1 commit into from
Jun 6, 2023

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Jun 5, 2023 •
edited

Description of Change

Remove patch which I think should now be unnecessary, given CI looks to pass without it.

Added in #30274.

Checklist

Release Notes

Notes: none

@codebytere codebytere requested a review from a team as a code owner June 5, 2023 12:56
deepak1556
deepak1556 approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must have been addressed with wasm streaming support in Node.js

@codebytere codebytere merged commit 7982c6c into main Jun 6, 2023
16 checks passed
@codebytere codebytere deleted the try-remove-arraybuffer-v8-patch branch June 6, 2023 08:22
@release-clerk
Copy link

release-clerk bot commented Jun 6, 2023

No Release Notes

@commit-lint commit-lint bot mentioned this pull request Aug 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@zcbenz zcbenz zcbenz approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

@jkleinsc jkleinsc Awaiting requested review from jkleinsc

@VerteDinde VerteDinde Awaiting requested review from VerteDinde

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees
No one assigned
Labels
no-backport semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@codebytere @ckerr @zcbenz @deepak1556