Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support node: prefixed requires in sandboxed renderer preloads #38729

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jun 10, 2023

Backport of #38567

See that PR for details.

Notes: node: prefixed requires are now supported in sandboxed renderer preloads for events, timers and url.

Co-authored-by: Milan Burda <milan.burda@gmail.com>
@trop trop bot requested a review from miniak June 10, 2023 18:37
@trop trop bot added 25-x-y backport This is a backport PR backport/requested 🗳 semver/minor backwards-compatible functionality labels Jun 10, 2023
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @electron/wg-releases on 2023-06-14

@codebytere codebytere merged commit 70fe0d9 into 25-x-y Jun 15, 2023
14 checks passed
@codebytere codebytere deleted the trop/25-x-y-bp-feat-support-node-prefixed-requires-in-sandboxed-renderer-preloads-1686422215282 branch June 15, 2023 09:59
@release-clerk
Copy link

release-clerk bot commented Jun 15, 2023

Release Notes Persisted

node: prefixed requires are now supported in sandboxed renderer preloads for events, timers and url.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
25-x-y backport This is a backport PR semver/minor backwards-compatible functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants