refactor: use constexpr lookup tables in gin helper #38818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add gin_helper::FromV8WithLowerLookup()
ckerr
added
target/26-x-y
miniak
approved these changes
Jun 19, 2023
|
No Release Notes |
|
I have automatically backported this PR to "26-x-y", please check out #38835 |
trop
bot
added
in-flight/26-x-y
merged/26-x-y
3 tasks
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
* feat: add gin_helper::FromV8WithLookup() feat: add gin_helper::FromV8WithLowerLookup() * refactor: use constexpr lookup table in gin Converters
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
A followup to #38771. Use
base::fixed_flat_mapforFromV8()string-to-value conversions.CC @miniak and @dsanders11 + all reviews welcomed.
Checklist
npm testpassesRelease Notes
Notes: none