feat: add senderIsMainFrame to messages sent via ipcRenderer.sendTo()
#38868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miniak
changed the title
isMainFrame to events sent via ipcRenderer.sendTo()isMainFrame to IPCs sent via ipcRenderer.sendTo()
miniak
changed the title
isMainFrame to IPCs sent via ipcRenderer.sendTo()isMainFrame to messages sent via ipcRenderer.sendTo()
miniak
added
semver/minor
miniak
force-pushed
the
miniak/ipc-renderer-send-to-is-main-frame
branch
from
6a8554f
to
475c2ae
Compare
deepak1556
reviewed
Jun 21, 2023
5 tasks
|
@miniak given we've now moved towards deprecating |
|
@codebytere yes it's a simple change that covers existing releases that can be backported |
…end-to-is-main-frame
miniak
changed the title
isMainFrame to messages sent via ipcRenderer.sendTo()senderIsMainFrame to messages sent via ipcRenderer.sendTo()
deepak1556
reviewed
Jul 19, 2023
deepak1556
approved these changes
Jul 19, 2023
electron-cation
bot
added
api-review/approved ✅
and removed
api-review/requested 🗳
labels
|
Release Notes Persisted
|
trop bot
added a commit
that referenced
this pull request
Jul 24, 2023
…o()` (#38868) * feat: add isMainFrame to events emitted via ipcRenderer.sendTo() * chore: rename isMainFrame to senderIsMainFrame Co-authored-by: Milan Burda <milan.burda@gmail.com>
trop bot
added a commit
that referenced
this pull request
Jul 24, 2023
…o()` (#38868) * feat: add isMainFrame to events emitted via ipcRenderer.sendTo() * chore: rename isMainFrame to senderIsMainFrame Co-authored-by: Milan Burda <milan.burda@gmail.com>
trop bot
added a commit
that referenced
this pull request
Jul 24, 2023
…o()` (#38868) * feat: add isMainFrame to events emitted via ipcRenderer.sendTo() * chore: rename isMainFrame to senderIsMainFrame Co-authored-by: Milan Burda <milan.burda@gmail.com>
|
I have automatically backported this PR to "26-x-y", please check out #39206 |
trop
bot
added
in-flight/26-x-y
and removed
target/26-x-y
|
I have automatically backported this PR to "24-x-y", please check out #39207 |
|
I have automatically backported this PR to "25-x-y", please check out #39208 |
trop
bot
added
in-flight/24-x-y
in-flight/25-x-y
and removed
target/24-x-y
codebytere
pushed a commit
that referenced
this pull request
Jul 26, 2023
…o()` (#38868) * feat: add isMainFrame to events emitted via ipcRenderer.sendTo() * chore: rename isMainFrame to senderIsMainFrame Co-authored-by: Milan Burda <milan.burda@gmail.com>
trop
bot
added
merged/24-x-y
codebytere
pushed a commit
that referenced
this pull request
Jul 27, 2023
…o()` (#39207) * feat: add `senderIsMainFrame` to messages sent via `ipcRenderer.sendTo()` (#38868) * feat: add isMainFrame to events emitted via ipcRenderer.sendTo() * chore: rename isMainFrame to senderIsMainFrame Co-authored-by: Milan Burda <milan.burda@gmail.com> * once -> emittedOnce --------- Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Milan Burda <milan.burda@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jul 27, 2023
…o()` (#39208) feat: add `senderIsMainFrame` to messages sent via `ipcRenderer.sendTo()` (#38868) * feat: add isMainFrame to events emitted via ipcRenderer.sendTo() * chore: rename isMainFrame to senderIsMainFrame Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Milan Burda <milan.burda@gmail.com>
trop
bot
added
merged/25-x-y
codebytere
pushed a commit
that referenced
this pull request
Jul 27, 2023
…o()` (#39206) feat: add `senderIsMainFrame` to messages sent via `ipcRenderer.sendTo()` (#38868) * feat: add isMainFrame to events emitted via ipcRenderer.sendTo() * chore: rename isMainFrame to senderIsMainFrame Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Milan Burda <milan.burda@gmail.com>
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
…o()` (electron#38868) * feat: add isMainFrame to events emitted via ipcRenderer.sendTo() * chore: rename isMainFrame to senderIsMainFrame
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
When
nodeIntegrationInSubFramesis enabled in the originatingwebContents, a child frame with a different origin is able to send an IPC viaipcRenderer.sendTo()and the receiver has currently no way of telling whether the IPC came from the main frame or not.The question is also whether
ipcRenderer.sendToshouldn't be deprecated as it can be replaced withMessageChannel+ipcRenderer.postMessage(), where the validation can be done in the main process before passing theMessagePortto the other renderer.cc @electron/wg-security
Checklist
npm testpassesRelease Notes
Notes: Added
senderIsMainFrameto messages sent viaipcRenderer.sendTo()