Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use generic capturer to list both screens and windows when possible #39111

Merged
merged 1 commit into from
Jul 21, 2023
Merged

fix: use generic capturer to list both screens and windows when possible #39111

merged 1 commit into from
Jul 21, 2023

Commits on Jul 21, 2023

  1. fix: use generic capturer to list both screens and windows when possible 

    Screensharing with PipeWire via XDG Desktop Portal requires explicit
user permission via permission dialogs. Chromium has separate tabs for
screens and windows and thus its portal implementation requests
permissions separately for each. However, the screencast portal has no
such limitation and supports both screens and windows in a single
request.

WebRTC now supports this type of capture in a new method called
called `CreateGenericCapturer`. The `desktopCapturer` implementation has
been modified to use it. Additionally, Chromium has been patched to use
same generic capturer to ensure that the source IDs remain valid for
`getUserMedia`.
    @aiddya
    aiddya committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    ffc1271 View commit details
    Browse the repository at this point in the history