fix: delete desktop capturers when they're not needed #39246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
Delete desktop capturer objects by resetting the DesktopMediaList objects that own them after the sources have been collected. Capturers that are not delegated are already being reset via a patch on NativeDesktopMediaList. That is not safe for delegated capturers as thumbnail generation depends on user events. Deleting the DesktopMediaList operation is safe for all capturers and releases OS capture resources as soon as possible. Co-authored-by: Athul Iddya <athul@iddya.com>
Adding a patch to workaround a Chromium issue: https://bugs.chromium.org/p/chromium/issues/detail?id=1467060 The patch can be removed when the issue is resolved. Co-authored-by: Athul Iddya <athul@iddya.com>
3 tasks
trop
bot
added
26-x-y
backport
jkleinsc
approved these changes
Jul 26, 2023
jkleinsc
deleted the
trop/26-x-y-bp-fix-delete-desktop-capturers-when-they-re-not-needed-1690360835964
branch
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #39194
See that PR for details.
Notes: Fixed
desktopCapturerthumbnail generation after screen sharing is cancelled on Wayland.