Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not resolve electron entrypoints on disk #39247

Merged
merged 1 commit into from
Jul 27, 2023
Merged

fix: do not resolve electron entrypoints on disk #39247

merged 1 commit into from
Jul 27, 2023
+25 −0

Conversation

MarshallOfSound
Copy link
Member

This wastes io cycles and can result in strange behaviour if this path actually exists on disk

Notes: no-notes

@MarshallOfSound MarshallOfSound added fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases target/22-x-y PR should also be added to the "22-x-y" branch. target/23-x-y PR should also be added to the "23-x-y" branch. target/24-x-y PR should also be added to the "24-x-y" branch. target/25-x-y PR should also be added to the "25-x-y" branch. target/26-x-y PR should also be added to the "26-x-y" branch. labels Jul 27, 2023
@MarshallOfSound MarshallOfSound requested a review from a team as a code owner July 27, 2023 00:07
@MarshallOfSound MarshallOfSound merged commit 8dea783 into main Jul 27, 2023
19 of 20 checks passed
@MarshallOfSound MarshallOfSound deleted the fix-electron-entry-resolve branch July 27, 2023 05:11
@release-clerk
Copy link

release-clerk bot commented Jul 27, 2023

No Release Notes

This was referenced Jul 27, 2023
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Jul 27, 2023

I have automatically backported this PR to "22-x-y", please check out #39248

@trop trop bot mentioned this pull request Jul 27, 2023
Merged
@trop trop bot mentioned this pull request Jul 27, 2023
Merged
@trop trop bot removed the target/22-x-y PR should also be added to the "22-x-y" branch. label Jul 27, 2023
@trop trop bot mentioned this pull request Jul 27, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Jul 27, 2023

I have automatically backported this PR to "23-x-y", please check out #39249

@trop
Copy link
Contributor

trop bot commented Jul 27, 2023

I have automatically backported this PR to "24-x-y", please check out #39250

@trop
Copy link
Contributor

trop bot commented Jul 27, 2023

I have automatically backported this PR to "25-x-y", please check out #39251

@trop trop bot removed the target/23-x-y PR should also be added to the "23-x-y" branch. label Jul 27, 2023
@trop
Copy link
Contributor

trop bot commented Jul 27, 2023

I have automatically backported this PR to "26-x-y", please check out #39252

@trop trop bot added in-flight/25-x-y in-flight/26-x-y merged/26-x-y PR was merged to the "26-x-y" branch. merged/25-x-y PR was merged to the "25-x-y" branch. merged/24-x-y PR was merged to the "24-x-y" branch merged/23-x-y PR was merged to the "23-x-y" branch. merged/22-x-y PR was merged to the "22-x-y" branch. and removed target/24-x-y PR should also be added to the "24-x-y" branch. target/25-x-y PR should also be added to the "25-x-y" branch. target/26-x-y PR should also be added to the "26-x-y" branch. in-flight/26-x-y in-flight/25-x-y in-flight/24-x-y labels Jul 27, 2023
@MarshallOfSound MarshallOfSound mentioned this pull request Aug 8, 2023
Merged
@codebytere codebytere mentioned this pull request Aug 14, 2023
Merged
4 tasks
win32ss pushed a commit to win32ss/supermium-electron that referenced this pull request Sep 24, 2023
@MarshallOfSound
fix: do not resolve electron entrypoints on disk (electron#39247)
8f5c9ef
@commit-lint commit-lint bot mentioned this pull request Oct 5, 2023
Open
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@MarshallOfSound
fix: do not resolve electron entrypoints on disk (electron#39247)
5a5b495
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees
No one assigned
Labels
fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases merged/22-x-y PR was merged to the "22-x-y" branch. merged/23-x-y PR was merged to the "23-x-y" branch. merged/24-x-y PR was merged to the "24-x-y" branch merged/25-x-y PR was merged to the "25-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MarshallOfSound @deepak1556 @VerteDinde