Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix hang when validating AppVeyor artifacts #39362

Merged
merged 1 commit into from
Aug 7, 2023
Merged

ci: fix hang when validating AppVeyor artifacts #39362

merged 1 commit into from
Aug 7, 2023

Conversation

jkleinsc
Copy link
Contributor

@jkleinsc jkleinsc commented Aug 3, 2023

Description of Change

Occasionally on build failures, the logic to detect if all artifacts have been uploaded to AppVeyor was hanging causing builds to run for 3 hours before timing out - eg https://ci.appveyor.com/project/electron-bot/electron-woa-testing/builds/47688239/job/02vd8tkwssqxt1ig.

It turns out that trying to fail the build in the on_finish step was causing the hang. This PR moves the logic to check the artifacts to the build step but leaves the actual uploading of artifacts in the on_finish step as we want to upload any artifacts we have even on build failure.

Checklist

Release Notes

Notes: none

@jkleinsc jkleinsc added fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases target/22-x-y PR should also be added to the "22-x-y" branch. target/23-x-y PR should also be added to the "23-x-y" branch. target/24-x-y PR should also be added to the "24-x-y" branch. target/25-x-y PR should also be added to the "25-x-y" branch. target/26-x-y PR should also be added to the "26-x-y" branch. labels Aug 3, 2023
VerteDinde
VerteDinde approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@codebytere codebytere merged commit 1eb6e45 into main Aug 7, 2023
19 checks passed
@codebytere codebytere deleted the fix-appveyor-hang branch August 7, 2023 07:51
@release-clerk
Copy link

release-clerk bot commented Aug 7, 2023

No Release Notes

@trop
Copy link
Contributor

trop bot commented Aug 7, 2023

I was unable to backport this PR to "25-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Aug 7, 2023

I was unable to backport this PR to "26-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/25-x-y PR should also be added to the "25-x-y" branch. label Aug 7, 2023
@trop
Copy link
Contributor

trop bot commented Aug 7, 2023

I was unable to backport this PR to "22-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/25-x-y needs-manual-bp/26-x-y and removed target/26-x-y PR should also be added to the "26-x-y" branch. labels Aug 7, 2023
@trop
Copy link
Contributor

trop bot commented Aug 7, 2023

I was unable to backport this PR to "23-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/22-x-y PR should also be added to the "22-x-y" branch. label Aug 7, 2023
@trop
Copy link
Contributor

trop bot commented Aug 7, 2023

I was unable to backport this PR to "24-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/22-x-y needs-manual-bp/23-x-y needs-manual-bp/24-x-y and removed target/23-x-y PR should also be added to the "23-x-y" branch. target/24-x-y PR should also be added to the "24-x-y" branch. labels Aug 7, 2023
jkleinsc added a commit that referenced this pull request Aug 7, 2023
@jkleinsc
ci: fix hang when validating AppVeyor artifacts (#39362)
1e19392 
(cherry picked from commit 1eb6e45)
@trop
Copy link
Contributor

trop bot commented Aug 7, 2023

@jkleinsc has manually backported this PR to "22-x-y", please check out #39398

jkleinsc added a commit that referenced this pull request Aug 7, 2023
@jkleinsc
ci: fix hang when validating AppVeyor artifacts (#39362) (#39397)
3e239ef 
(cherry picked from commit 1eb6e45)
@trop trop bot added the merged/26-x-y PR was merged to the "26-x-y" branch. label Aug 7, 2023
@trop trop bot mentioned this pull request Aug 7, 2023
Merged
trop bot added a commit that referenced this pull request Aug 7, 2023
@trop @jkleinsc
ci: fix hang when validating AppVeyor artifacts (#39362)
3d8fafe 
(cherry picked from commit 1eb6e45)

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
trop bot added a commit that referenced this pull request Aug 7, 2023
@trop @jkleinsc
ci: fix hang when validating AppVeyor artifacts (#39362)
3bbebc5 
(cherry picked from commit 1eb6e45)

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
@trop trop bot mentioned this pull request Aug 7, 2023
Merged
@trop trop bot added in-flight/24-x-y in-flight/25-x-y merged/22-x-y PR was merged to the "22-x-y" branch. and removed in-flight/22-x-y labels Aug 7, 2023
jkleinsc added a commit that referenced this pull request Aug 7, 2023
@jkleinsc
ci: fix hang when validating AppVeyor artifacts (#39398)
b026a66 
ci: fix hang when validating AppVeyor artifacts (#39362)

(cherry picked from commit 1eb6e45)
(cherry picked from commit dc7b42e)
@trop trop bot mentioned this pull request Aug 7, 2023
Merged
trop bot added a commit that referenced this pull request Aug 7, 2023
@trop @jkleinsc
ci: fix hang when validating AppVeyor artifacts (#39362)
b81642e 
(cherry picked from commit 1eb6e45)
(cherry picked from commit dc7b42e)

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
@trop trop bot added in-flight/23-x-y merged/24-x-y PR was merged to the "24-x-y" branch and removed in-flight/24-x-y labels Aug 7, 2023
jkleinsc added a commit that referenced this pull request Aug 7, 2023
@trop @jkleinsc
ci: fix hang when validating AppVeyor artifacts (#39399)
08dd282 
ci: fix hang when validating AppVeyor artifacts (#39362)

(cherry picked from commit 1eb6e45)

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
@trop trop bot added merged/25-x-y PR was merged to the "25-x-y" branch. and removed in-flight/25-x-y labels Aug 7, 2023
jkleinsc added a commit that referenced this pull request Aug 7, 2023
@trop @jkleinsc
ci: fix hang when validating AppVeyor artifacts (#39400)
c697368 
ci: fix hang when validating AppVeyor artifacts (#39362)

(cherry picked from commit 1eb6e45)

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
@trop trop bot added merged/23-x-y PR was merged to the "23-x-y" branch. and removed in-flight/23-x-y labels Aug 8, 2023
codebytere pushed a commit that referenced this pull request Aug 8, 2023
@trop @jkleinsc
ci: fix hang when validating AppVeyor artifacts (#39401)
b2047d7 
ci: fix hang when validating AppVeyor artifacts (#39362)

(cherry picked from commit 1eb6e45)
(cherry picked from commit dc7b42e)

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
win32ss pushed a commit to win32ss/supermium-electron that referenced this pull request Sep 24, 2023
@jkleinsc
ci: fix hang when validating AppVeyor artifacts (electron#39362)
deac262
@commit-lint commit-lint bot mentioned this pull request Oct 12, 2023
Open
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@jkleinsc
ci: fix hang when validating AppVeyor artifacts (electron#39362)
4f4bf2f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees
No one assigned
Labels
fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases merged/22-x-y PR was merged to the "22-x-y" branch. merged/23-x-y PR was merged to the "23-x-y" branch. merged/24-x-y PR was merged to the "24-x-y" branch merged/25-x-y PR was merged to the "25-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jkleinsc @VerteDinde @codebytere